Skip to content

Include old & new values for changes in the plan #4072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denik merged 1 commit into from
Dec 3, 2025
+239 −77
Merged

Include old & new values for changes in the plan #4072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions acceptance/bundle/artifacts/whl_dynamic/out.plan_update.direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,13 +148,19 @@
"changes": {
"local": {
"environments[0].spec.dependencies[0]": {
"action": "update"
"action": "update",
"old": "/Workspace/Users/[USERNAME]/.bundle/test-bundle/default/artifacts/.internal/my_test_code-0.0.1+[UNIX_TIME_NANOS][2]-py3-none-any.whl",
"new": "/Workspace/Users/[USERNAME]/.bundle/test-bundle/default/artifacts/.internal/my_test_code-0.0.1+[UNIX_TIME_NANOS][0]-py3-none-any.whl"
},
"tasks[task_key='TestTask'].for_each_task.task.libraries[0].whl": {
"action": "update"
"action": "update",
"old": "/Workspace/Users/[USERNAME]/.bundle/test-bundle/default/artifacts/.internal/my_test_code-0.0.1+[UNIX_TIME_NANOS][2]-py3-none-any.whl",
"new": "/Workspace/Users/[USERNAME]/.bundle/test-bundle/default/artifacts/.internal/my_test_code-0.0.1+[UNIX_TIME_NANOS][0]-py3-none-any.whl"
},
"tasks[task_key='TestTask'].libraries[0].whl": {
"action": "update"
"action": "update",
"old": "/Workspace/Users/[USERNAME]/.bundle/test-bundle/default/artifacts/.internal/my_test_code-0.0.1+[UNIX_TIME_NANOS][2]-py3-none-any.whl",
"new": "/Workspace/Users/[USERNAME]/.bundle/test-bundle/default/artifacts/.internal/my_test_code-0.0.1+[UNIX_TIME_NANOS][0]-py3-none-any.whl"
}
},
"remote": {
Expand Down
12 changes: 9 additions & 3 deletions acceptance/bundle/migrate/basic/out.plan_update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@
"changes": {
"local": {
"name": {
"action": "update"
"action": "update",
"old": "Test Migration Job",
"new": "Test Migrated Job"
}
},
"remote": {
Expand Down Expand Up @@ -173,10 +175,14 @@
"changes": {
"local": {
"name": {
"action": "update"
"action": "update",
"old": "Test Migration Pipeline",
"new": "Test Migrated Pipeline"
},
"tags['myjob_name']": {
"action": "update"
"action": "update",
"old": "Test Migration Job",
"new": "Test Migrated Job"
}
},
"remote": {
Expand Down
7 changes: 5 additions & 2 deletions acceptance/bundle/migrate/dashboards/out.plan_after_migrate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,15 @@
"changes": {
"local": {
"etag": {
"action": "skip"
"action": "skip",
"old": "[NUMID]"
}
},
"remote": {
"serialized_dashboard": {
"action": "skip"
"action": "skip",
"old": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Dashboard test bundle-deploy-dashboard\"}]}\n",
"new": "{\"pages\":[{\"displayName\":\"Dashboard test bundle-deploy-dashboard\",\"name\":\"02724bf2\",\"pageType\":\"PAGE_TYPE_CANVAS\"}]}\n"
}
}
}
Expand Down
5 changes: 4 additions & 1 deletion acceptance/bundle/migrate/runas/out.plan.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,10 @@
"changes": {
"remote": {
"run_as": {
"action": "skip"
"action": "skip",
"old": {
"service_principal_name": "[UUID]"
}
}
}
}
Expand Down
20 changes: 15 additions & 5 deletions acceptance/bundle/resource_deps/id_chain/out.plan_update.direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@
"changes": {
"local": {
"description": {
"action": "update"
"action": "update",
"old": "aa_desc",
"new": "aa_new_desc"
}
},
"remote": {
Expand Down Expand Up @@ -113,7 +115,9 @@
"changes": {
"local": {
"description": {
"action": "update"
"action": "update",
"old": "prefix [NUMID]",
"new": "new_prefix [NUMID]"
}
},
"remote": {
Expand Down Expand Up @@ -182,7 +186,9 @@
"changes": {
"local": {
"description": {
"action": "update"
"action": "update",
"old": "prefix [NUMID]",
"new": "new_prefix [NUMID]"
}
},
"remote": {
Expand Down Expand Up @@ -251,7 +257,9 @@
"changes": {
"local": {
"description": {
"action": "update"
"action": "update",
"old": "prefix [NUMID]",
"new": "new_prefix [NUMID]"
}
},
"remote": {
Expand Down Expand Up @@ -320,7 +328,9 @@
"changes": {
"local": {
"description": {
"action": "update"
"action": "update",
"old": "prefix [NUMID]",
"new": "new_prefix [NUMID]"
}
},
"remote": {
Expand Down
4 changes: 3 additions & 1 deletion acceptance/bundle/resource_deps/jobs_update_remote/out.plan_update.direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,9 @@
"reason": "server_side_default"
},
"trigger.periodic.unit": {
"action": "update"
"action": "update",
"old": "DAYS",
"new": "HOURS"
},
"webhook_notifications": {
"action": "skip",
Expand Down
8 changes: 6 additions & 2 deletions acceptance/bundle/resource_deps/pipelines_recreate/out.plan_update.direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@
"changes": {
"local": {
"description": {
"action": "update"
"action": "update",
"old": "depends on foo id [FOO_ID]",
"new": "depends on foo id ${resources.pipelines.foo.id}"
}
},
"remote": {
Expand Down Expand Up @@ -89,7 +91,9 @@
"changes": {
"local": {
"catalog": {
"action": "recreate"
"action": "recreate",
"old": "mycatalog",
"new": "mynewcatalog"
}
}
}
Expand Down
34 changes: 26 additions & 8 deletions ...ptance/bundle/resources/clusters/deploy/update-and-resize-autoscale/out.plan_.direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,15 @@
"changes": {
"local": {
"autoscale": {
"action": "update"
"action": "update",
"new": {
"max_workers": 4,
"min_workers": 2
}
},
"num_workers": {
"action": "update"
"action": "update",
"old": 2
}
}
}
Expand Down Expand Up @@ -81,10 +86,14 @@
"changes": {
"local": {
"autoscale.max_workers": {
"action": "update"
"action": "update",
"old": 4,
"new": 5
},
"autoscale.min_workers": {
"action": "update"
"action": "update",
"old": 2,
"new": 3
}
}
}
Expand Down Expand Up @@ -122,10 +131,14 @@
"changes": {
"local": {
"autoscale.max_workers": {
"action": "resize"
"action": "resize",
"old": 5,
"new": 6
},
"autoscale.min_workers": {
"action": "resize"
"action": "resize",
"old": 3,
"new": 4
}
}
}
Expand Down Expand Up @@ -160,10 +173,15 @@
"changes": {
"local": {
"autoscale": {
"action": "resize"
"action": "resize",
"old": {
"max_workers": 6,
"min_workers": 4
}
},
"num_workers": {
"action": "resize"
"action": "resize",
"new": 3
}
}
}
Expand Down
16 changes: 12 additions & 4 deletions acceptance/bundle/resources/clusters/deploy/update-and-resize/out.plan_.direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@
"changes": {
"local": {
"num_workers": {
"action": "update"
"action": "update",
"old": 2,
"new": 3
}
}
}
Expand Down Expand Up @@ -85,7 +87,9 @@
"changes": {
"local": {
"num_workers": {
"action": "resize"
"action": "resize",
"old": 3,
"new": 4
}
}
}
Expand Down Expand Up @@ -123,10 +127,14 @@
"changes": {
"local": {
"num_workers": {
"action": "resize"
"action": "resize",
"old": 4,
"new": 5
},
"spark_conf['spark.executor.memory']": {
"action": "update"
"action": "update",
"old": "2g",
"new": "4g"
}
}
}
Expand Down
3 changes: 2 additions & 1 deletion acceptance/bundle/resources/dashboards/delete-trashed-out-of-band/out.plan.direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
"changes": {
"local": {
"etag": {
"action": "skip"
"action": "skip",
"old": [ETAG]
}
}
}
Expand Down
7 changes: 5 additions & 2 deletions acceptance/bundle/resources/dashboards/simple/out.plan.direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,15 @@
"changes": {
"local": {
"etag": {
"action": "skip"
"action": "skip",
"old": [ETAG]
}
},
"remote": {
"serialized_dashboard": {
"action": "skip"
"action": "skip",
"old": "{ }\n",
"new": "{}\n"
}
}
}
Expand Down
8 changes: 6 additions & 2 deletions acceptance/bundle/resources/grants/schemas/change_privilege/out.plan2.direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,14 @@
"changes": {
"local": {
"grants[0].privileges[0]": {
"action": "update"
"action": "update",
"old": "CREATE_TABLE",
"new": "APPLY_TAG"
},
"grants[0].privileges[1]": {
"action": "update"
"action": "update",
"old": "USE_SCHEMA",
"new": "CREATE_TABLE"
}
}
}
Expand Down
8 changes: 6 additions & 2 deletions acceptance/bundle/resources/grants/volumes/out.plan2.direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,14 @@
"changes": {
"local": {
"grants[0].privileges[0]": {
"action": "update"
"action": "update",
"old": "READ_VOLUME",
"new": "MANAGE"
},
"grants[0].privileges[1]": {
"action": "update"
"action": "update",
"old": "WRITE_VOLUME",
"new": "READ_VOLUME"
}
}
}
Expand Down
15 changes: 14 additions & 1 deletion acceptance/bundle/resources/jobs/delete_task/out.plan_update.direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,20 @@
"changes": {
"local": {
"tasks[task_key='TestTask1']": {
"action": "update"
"action": "update",
"old": {
"existing_cluster_id": "0717-132531-5opeqon1",
"libraries": [
{
"whl": "/Workspace/Users/[email protected]/mywheel.whl"
}
],
"python_wheel_task": {
"entry_point": "run",
"package_name": "whl"
},
"task_key": "TestTask1"
}
}
},
"remote": {
Expand Down
3 changes: 2 additions & 1 deletion acceptance/bundle/resources/jobs/remote_add_tag/out.plan_post_update.direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@
"reason": "server_side_default"
},
"tags['new_tag']": {
"action": "update"
"action": "update",
"new": "new_value"
},
"timeout_seconds": {
"action": "skip",
Expand Down
4 changes: 3 additions & 1 deletion acceptance/bundle/resources/jobs/update/out.plan_update.direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@
"changes": {
"local": {
"trigger.periodic.unit": {
"action": "update"
"action": "update",
"old": "DAYS",
"new": "HOURS"
}
},
"remote": {
Expand Down
4 changes: 3 additions & 1 deletion acceptance/bundle/resources/jobs/update_single_node/out.plan_update.direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@
"changes": {
"local": {
"trigger.periodic.unit": {
"action": "update"
"action": "update",
"old": "DAYS",
"new": "HOURS"
}
},
"remote": {
Expand Down
Loading