Updated State open to use Json Decoder for Large Int Precision #4136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varundeepsaini
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
Contributor
Author
|
@andrewnester @denik |
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Contributor
Author
|
@denik fixed the linter error, coudl you please queue the tests again |
Contributor
|
Thanks @varundeepsaini this is a great find and your fix is valid. I have somewhat more general one here: #4138 |
Contributor
Author
|
thanks, i'll close this pr then, and rebase + update the tests in the reverse dependancy pr |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
## Changes Instead of parsing into any and then converting into the target type, we now store json.RawMessage and then parse into target type when needed. ## Why One issue it fixes is that JSON parser by default parses integers as float64, losing precision. This was found by @varundeepsaini and a fix is proposed in #4136 This PR is more general though, fully relying on the type to parse itself and it should more efficient as well as we're not walking the type twice & we're not having 2 copies of it. ## Tests New test where int64 field is initialized with large numbers. It fails on main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix precision loss when loading state with large integer IDs
Problem
json.Unmarshaldecodes numbers asfloat64when the destination isany, causing precision loss for integers > 2^53 (like job IDs).Solution
Use
json.NewDecoderwithUseNumber()to preserve integer precision.Tests
Added unit tests for
dstatepackage, including one that verifies the precision fix.