direct: parse state via json.RawMessage into appropriate type #4138
+321
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
changed the title
andrewnester
approved these changes
Dec 12, 2025
Collaborator
|
Commit: 9312b3f
8 interesting tests: 7 KNOWN, 1 SKIP
Top 24 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: f915956
21 interesting tests: 13 flaky, 7 KNOWN, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Instead of parsing into any and then converting into the target type, we now store json.RawMessage and then parse into target type when needed.
Why
One issue it fixes is that JSON parser by default parses integers as float64, losing precision. This was found by @varundeepsaini and a fix is proposed in #4136
This PR is more general though, fully relying on the type to parse itself and it should more efficient as well as we're not walking the type twice & we're not having 2 copies of it.
Tests
New test where int64 field is initialized with large numbers. It fails on main.