Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 42 additions & 2 deletions credentials/u2m/cache/file.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ func (c *fileTokenCache) Store(key string, t *oauth2.Token) error {
if err != nil {
return fmt.Errorf("marshal: %w", err)
}
return os.WriteFile(c.fileLocation, raw, ownerReadWrite)
return c.atomicWriteFile(raw)
}

// Lookup implements the TokenCache interface.
Expand Down Expand Up @@ -151,7 +151,7 @@ func (c *fileTokenCache) init() error {
if err != nil {
return fmt.Errorf("marshal: %w", err)
}
if err := os.WriteFile(c.fileLocation, raw, ownerReadWrite); err != nil {
if err := c.atomicWriteFile(raw); err != nil {
return fmt.Errorf("write: %w", err)
}
}
Expand All @@ -177,3 +177,43 @@ func (c *fileTokenCache) load() (*tokenCacheFile, error) {
}
return f, nil
}

// atomicWriteFile writes data to the file atomically by first writing to a
// temporary file in the same directory and then renaming it to the target.
// This prevents corruption from interrupted writes.
func (c *fileTokenCache) atomicWriteFile(data []byte) error {
dir := filepath.Dir(c.fileLocation)
tmp, err := os.CreateTemp(dir, ".token-cache-*.tmp")
if err != nil {
return fmt.Errorf("create temp file: %w", err)
}
tmpName := tmp.Name()

success := false
defer func() {
if !success {
os.Remove(tmpName)
}
}()

if err := tmp.Chmod(ownerReadWrite); err != nil {
tmp.Close()
return fmt.Errorf("chmod temp file: %w", err)
}

if _, err := tmp.Write(data); err != nil {
tmp.Close()
return fmt.Errorf("write temp file: %w", err)
}

if err := tmp.Close(); err != nil {
return fmt.Errorf("close temp file: %w", err)
}

if err := os.Rename(tmpName, c.fileLocation); err != nil {
return fmt.Errorf("rename temp file: %w", err)
}

success = true
return nil
}
Loading