fix double read as float: issue 18 #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Sloan <[email protected]>
up-stevesloan
requested review from
benc-db,
gopalldb,
jackyhu-db,
jprakash-db and
yunbodeng-db
as code owners
Collaborator
|
@up-stevesloan Thanks for the contribution, the changes looks good to me |
jprakash-db
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #18
I successfully tested this with the local unit tests:
poetry run python3 -m pytest tests/test_local/*.pyI also was able to prove, in the context of our alembic setup, that this prevented the erroneous messages and alter column commands in the migration script.
I do not have a Databricks workspace available with which I'm comfortable running the
e2etests.