Upgrade dependencies, fix a few lints #22
Conversation
| std::env::set_var("PROTOC", protoc_bin_vendored::protoc_bin_path().unwrap()); | ||
| tonic_build::compile_protos("zerobus_service.proto") |
There was a problem hiding this comment.
I initially added this so that people using the SDK wouldn't have to have protoc installed to be able to run the SDK. Does this remove that?
There was a problem hiding this comment.
Hmmm, it actually forces you to have your own installed, I think that makes sense I'll revert this.
| async-trait = "0.1" | ||
| prost = "0.13.3" | ||
| prost-types = "0.13.3" | ||
| prost = "0.14.1" |
There was a problem hiding this comment.
@gotocoding-DB expressed a concern regarding this how we use an older version in Universe and thus this would make it harder to import the SDK into Universe. We'd need to bump up the Universe version which is a bit of a hassle.
elenagaljak-db
left a comment
elenagaljak-db
left a comment
There was a problem hiding this comment.
Can you please update the NEXT_CHANGELOG.md file as well?
Also, I see that you didn't sign your commits which will be a blocker for merge. You should retroactively sign your commits with gpg.
3 participants
What changes are proposed in this pull request?
Upgrade dependencies, namely tonic, prost and tonic-reflect to their latest versions.
How is this tested?
Tests build and pass