-
Notifications
You must be signed in to change notification settings - Fork 2
Upgrade dependencies, fix a few lints #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| fn main() { | ||
| std::env::set_var("PROTOC", protoc_bin_vendored::protoc_bin_path().unwrap()); | ||
| tonic_build::compile_protos("zerobus_service.proto") | ||
|
Comment on lines
2
to
3
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I initially added this so that people using the SDK wouldn't have to have protoc installed to be able to run the SDK. Does this remove that?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmmm, it actually forces you to have your own installed, I think that makes sense I'll revert this. |
||
| tonic_prost_build::compile_protos("zerobus_service.proto") | ||
| .unwrap_or_else(|e| panic!("Failed to compile protos {:?}", e)); | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,6 @@ | ||
| fn main() -> Result<(), Box<dyn std::error::Error>> { | ||
| tonic_build::configure() | ||
| fn main() -> Result<(), std::io::Error> { | ||
| tonic_prost_build::configure() | ||
| .build_server(true) | ||
| .build_client(false) | ||
| .compile_protos(&["../sdk/zerobus_service.proto"], &["../sdk"])?; | ||
|
|
||
| Ok(()) | ||
| .compile_protos(&["../sdk/zerobus_service.proto"], &["../sdk"]) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gotocoding-DB expressed a concern regarding this how we use an older version in Universe and thus this would make it harder to import the SDK into Universe. We'd need to bump up the Universe version which is a bit of a hassle.