Completed execution path + failing test #74
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported over the concepts from the previous version into this structure. The
tests/distributed_execution.rsis now a failing test due to a proto serialization bug around the custom codec.I don't have time to further look into it today. I would like this PR merged though if possible, and the fix for the failing test as a subsequent PR. This way it unblocks adding examples, tests, and fixes or reworks.
Brief summary of changes, docs and readme to follow in subsequent smaller PRs
ExecutionStagenow has anassignmethod which will recursively add worker urls to all tasks in the tree. It is currently done for the entire tree whenExecutionStage::execute()is called, but it can be improved by lazily doing it before sending out a child stage to workers.DoGetproto consists of anExecutionStageProtoand the partition to execute.PartitionIsolatorExecnode was ported over to allow for usingRepartitionExecsunchanged, only showing them their allowed partitionsCombinedRecordBatchStreamported over for scatter gather from child stagesChallenges:
ChannelManagerto work with theFlightClient. The high level flight client is a lot easier to use and it seems to want to take tonicChannels. Happy to have this fixed or refactored.