Skip to content

tests: skip minio-dependent tests when minio is not installed #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sarpit2907 wants to merge 2 commits into from
Closed

tests: skip minio-dependent tests when minio is not installed #1309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47666cf
tests: fix expected ordering in relational_operand (#1205)
sarpit2907 Jan 7, 2026
e008999
tests: skip minio-dependent tests when minio is not installed
sarpit2907 Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
from typing import Dict, List

import certifi
import minio
import networkx as nx
import pytest
minio = pytest.importorskip("minio")
import urllib3
from packaging import version

Expand Down
2 changes: 1 addition & 1 deletion tests/test_relational_operand.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,8 +630,8 @@ def test_top_restriction_with_keywords(self, schema_simp_pop):
]
assert key.fetch(as_dict=True) == [
{"id": 2, "key": 6},
{"id": 2, "key": 5},
{"id": 1, "key": 5},
{"id": 2, "key": 5},
Copy link
Member

@dimitri-yatsenko dimitri-yatsenko Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will not need to fix this since .fetch does not preserve order in this case. This is related to #1242 We have addressed this in DataJoint 2.0 (in review now).

{"id": 0, "key": 4},
{"id": 1, "key": 4},
{"id": 2, "key": 4},
Expand Down
Loading