Conversation
Summary of ChangesHello @Qirui-jiao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the video processing functionalities within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces several new video processing mappers to data_juicer, including VggtMapper, VideoCameraCalibrationStaticDeepcalibMapper, VideoCameraCalibrationStaticMogeMapper, VideoUndistortMapper, and VideoWholeBodyPoseEstimationMapper. These mappers enable functionalities such as extracting camera pose and depth information, calibrating static cameras, undistorting videos, and estimating whole-body poses. The code also includes necessary dependency installations and model preparations. Review comments suggest adding checks for the existence of specific keys in the sample metadata, version compatibility for opencv-contrib-python, error handling for camera parameter initialization and file concatenation, and ensuring submodule updates succeed in VideoCameraPoseMapper.
|
Updates on Feb 7:
|
video_camera_pose_mapper: Extract camera poses with MegaSaM and MoGe-2.