Skip to content

Enhance error handling for collection entity dialogs#3026

Merged
arsen-afaunov merged 7 commits intomainfrom
CHARTS-11508-fix-workbook-and-collection-creation-error-handling
Oct 20, 2025
Merged

Enhance error handling for collection entity dialogs#3026
arsen-afaunov merged 7 commits intomainfrom
CHARTS-11508-fix-workbook-and-collection-creation-error-handling

Conversation

@arsen-afaunov
Copy link
Copy Markdown
Contributor

@arsen-afaunov arsen-afaunov commented Oct 16, 2025

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 16, 2025 •
edited
Loading

📦 Statoscope quick diff with main-branch:

⏱ Build time: 581 ms (1.07%)

⚖️ Initial size: 0.53 kb (0.01%)

🕵️ Validation errors: 0

Full Statoscope report could be found here ↗️

@datalens-weblate-robot
Copy link
Copy Markdown
Contributor

datalens-weblate-robot commented Oct 16, 2025

i18n-check

The following components have not been translated

component.collections-structure (ru)
component.collections-structure (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 16, 2025 •
edited
Loading

E2E Tests Farm

Playwright test results

passed  419 passed
flaky  6 flaky
skipped  1 skipped

Details

stats  426 tests across 171 suites
duration  4 minutes, 9 seconds
commit  40f340f

Flaky tests

basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Preview with forbidden export › Wizard preview - Export menu item is disabled if export is forbidden on connection
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Preview with forbidden export › Ql preview - Export menu item is disabled if export is forbidden on connection
basic › suites/dash/revisions/revisionsListWithCreationDashboards.test.ts › Dashboards - Versioning › Creating a dashboard, editing, saving as a draft, making the draft version relevant
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Required fields validation
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Parameter name validation
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Parameter default_value validation [number]

Skipped tests

basic › suites/wizard/combined-chart/layers-and-multidatasets.test.ts › Multi-faceted charts with layers › The data on the X-axis must be formed correctly from two datasets

👉 Link with detailed report: report

Last updated: 2025-10-20 12:57:09 MSK

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 16, 2025 •
edited
Loading

E2E Tests

Playwright test results

passed  185 passed
flaky  2 flaky
skipped  2 skipped

Details

stats  189 tests across 105 suites
duration  4 minutes, 20 seconds
commit  bd7bb0f

Flaky tests

opensource › opensource-suites/dash/revisions/revisionsListWithCreationDashboards.test.ts › Dashboards - Versioning › Creating a dashboard, editing, saving as a draft, making the draft version relevant
opensource › opensource-suites/wizard/visualizations/pivot-table/export.test.ts › Wizard › Pivot table › Export to xlsx

Skipped tests

opensource › opensource-suites/dash/revisions/revisionsList.test.ts › Dashboards - Versioning › Dashboard with a long list of revisions, checking the upload and the updated list of revisions
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Manual selectors with aliases don't affect each other before applying when auto-update is disabled

👉 Link with detailed report: report

@arsen-afaunov arsen-afaunov requested review from jhoncool and removed request for korvin89 October 16, 2025 14:03
@datalens-weblate-robot
Copy link
Copy Markdown
Contributor

datalens-weblate-robot commented Oct 17, 2025

i18n-check

The following components have not been translated

component.collections-structure (ru)
component.collections-structure (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

jhoncool
jhoncool reviewed Oct 17, 2025
View reviewed changes
@datalens-weblate-robot
Copy link
Copy Markdown
Contributor

datalens-weblate-robot commented Oct 17, 2025

i18n-check

The following components have not been translated

component.collections-structure (ru)
component.collections-structure (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

jhoncool
jhoncool previously approved these changes Oct 17, 2025
View reviewed changes
@datalens-weblate-robot
Copy link
Copy Markdown
Contributor

datalens-weblate-robot commented Oct 17, 2025

i18n-check

The following components have not been translated

component.collections-structure (ru)
component.collections-structure (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

@datalens-weblate-robot datalens-weblate-robot mentioned this pull request Oct 20, 2025
Merged
@datalens-weblate-robot
Copy link
Copy Markdown
Contributor

datalens-weblate-robot commented Oct 20, 2025

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

@datalens-weblate-robot @dtikhonova
Translations update from Weblate Gravity for PR #3026 (#3041)
f36def1 
Co-authored-by: Darya Tikhonova <tihonova-d@yandex-team.ru>
Co-authored-by: Matthew Casserly <matveymc@yandex-team.ru>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 20, 2025 •
edited
Loading

E2E Tests

Playwright test results

passed  184 passed
flaky  3 flaky
skipped  2 skipped

Details

stats  189 tests across 105 suites
duration  2 minutes, 51 seconds
commit  40f340f

Flaky tests

opensource › opensource-suites/dash/revisions/revisionsListWithCreationDashboards.test.ts › Dashboards - Versioning › Creating a dashboard, editing, saving as a draft, making the draft version relevant
opensource › opensource-suites/ql/connections/selectSQLConnection.test.ts › SQL connection selection › The connection is made automatically if the SQL chart was created from the connection page
opensource › opensource-suites/wizard/visualizations/flat-table/sorting.test.ts › Wizard › Flat table › Tree column sorting

Skipped tests

opensource › opensource-suites/dash/revisions/revisionsList.test.ts › Dashboards - Versioning › Dashboard with a long list of revisions, checking the upload and the updated list of revisions
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Manual selectors with aliases don't affect each other before applying when auto-update is disabled

🧐 Links with traces:

👉 Link with detailed report: report

🐳 Link with docker compose logs: logs

Last updated: 2025-10-20 12:53:42 MSK

@arsen-afaunov arsen-afaunov merged commit b0f6d29 into main Oct 20, 2025
13 checks passed
@arsen-afaunov arsen-afaunov deleted the CHARTS-11508-fix-workbook-and-collection-creation-error-handling branch October 20, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhoncool jhoncool jhoncool approved these changes

@mournfulCoroner mournfulCoroner mournfulCoroner approved these changes

Assignees

No one assigned

Labels

changelog component/general type/fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arsen-afaunov @datalens-weblate-robot @jhoncool @mournfulCoroner