fix usage of sedlex and upgrade to sedlex 3.5#555
Merged
davesnx merged 1 commit intodavesnx:mainfrom Aug 12, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Owner
|
Thanks hugo. Will merge and add a few unit tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upcoming release of sedlex (ocaml/opam-repository#27959) revealed a bug in styled-ppx.
Utf8 literals in sedlex patterns was previously not working.
The non_ascii pattern also triggered a compile time error with sedlex 3.5.
Its definition was suspicious and I attempted to fix it according to the spec.
See the opam release ocaml/opam-repository#27959
See the sedlex PR adding support for utf8 litterals and adding more checks ocaml-community/sedlex#127