dbeaver/dbeaver#38710 fixed non-turso hostnames+ports #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nexus6v2
force-pushed
the
dbeaver/dbeaver#38710-lisql-url-fix
branch
from
a630ff0 to
a591c02
Compare
Nexus6v2
force-pushed
the
dbeaver/dbeaver#38710-lisql-url-fix
branch
from
a591c02 to
22094a9
Compare
com.dbeaver.jdbc.driver.libsql/src/main/java/com/dbeaver/jdbc/driver/libsql/LibSqlUtils.java
Outdated
Show resolved
Hide resolved
...eaver.jdbc.driver.libsql/src/test/java/com/dbeaver/jdbc/upd/driver/test/LibSqlUtilsTest.java
Outdated
Show resolved
Hide resolved
| ); | ||
| } | ||
|
|
||
| String formattedUrl = url.replaceFirst("jdbc:dbeaver:libsql:", ""); |
Member
There was a problem hiding this comment.
This will replace just the first occurrence of jdbc:dbeaver:libsql:. Did you want to trim it if it's in the beginning?
Member
There was a problem hiding this comment.
Then please either add a regex anchor or put a startsWith check.
serge-rider
requested changes
Jul 29, 2025
...dbeaver.jdbc.driver.libsql/src/main/java/com/dbeaver/jdbc/driver/libsql/LibSqlConstants.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the url parsing when providing protocol in server url and/or using ports
(default protocol is still https)