-
Notifications
You must be signed in to change notification settings - Fork 15
dbeaver/dbeaver#38710 fixed non-turso hostnames+ports #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
...er.jdbc.driver.libsql/src/test/java/com/dbeaver/jdbc/upd/driver/test/LibSqlUtilsTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /* | ||
| * DBeaver - Universal Database Manager | ||
| * Copyright (C) 2010-2025 DBeaver Corp | ||
| * | ||
| * All Rights Reserved. | ||
| * | ||
| * NOTICE: All information contained herein is, and remains | ||
| * the property of DBeaver Corp and its suppliers, if any. | ||
| * The intellectual and technical concepts contained | ||
| * herein are proprietary to DBeaver Corp and its suppliers | ||
| * and may be covered by U.S. and Foreign Patents, | ||
| * patents in process, and are protected by trade secret or copyright law. | ||
| * Dissemination of this information or reproduction of this material | ||
| * is strictly forbidden unless prior written permission is obtained | ||
| * from DBeaver Corp. | ||
| */ | ||
| package com.dbeaver.jdbc.upd.driver.test; | ||
|
|
||
| import com.dbeaver.jdbc.driver.libsql.LibSqlException; | ||
| import com.dbeaver.jdbc.driver.libsql.LibSqlUtils; | ||
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
|
|
||
| public class LibSqlUtilsTest { | ||
|
|
||
| @Test | ||
| public void testFormatUrl() throws LibSqlException { | ||
| Assert.assertThrows( | ||
| LibSqlException.class, | ||
| () -> LibSqlUtils.validateAndFormatUrl("localhost") | ||
| ); | ||
|
|
||
| assertUrlFormat("jdbc:dbeaver:libsql:http://localhost", "http://localhost"); | ||
| assertUrlFormat("jdbc:dbeaver:libsql:https://localhost", "https://localhost"); | ||
| assertUrlFormat("jdbc:dbeaver:libsql:http://localhost:8080", "http://localhost:8080"); | ||
| assertUrlFormat("jdbc:dbeaver:libsql:libsql://localhost", "https://localhost"); | ||
| assertUrlFormat("libsql://turso.url.my-hostname-1", "https://turso.url.my-hostname-1"); | ||
| assertUrlFormat("libsql://turso.url.my-hostname-1:8080", "https://turso.url.my-hostname-1:8080"); | ||
| } | ||
|
|
||
| private void assertUrlFormat(String input, String expected) throws LibSqlException { | ||
| Assert.assertEquals(expected, LibSqlUtils.validateAndFormatUrl(input)); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will replace just the first occurrence of
jdbc:dbeaver:libsql:. Did you want to trim it if it's in the beginning?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then please either add a regex anchor or put a
startsWithcheck.