-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add new-syle YAML unparsed metric #12157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12157 +/- ##
==========================================
- Coverage 91.40% 91.37% -0.03%
==========================================
Files 203 203
Lines 25144 25207 +63
==========================================
+ Hits 22982 23033 +51
- Misses 2162 2174 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
b833b17 to
77e7cc4
Compare
4f23379 to
3bc5c35
Compare
ef95e92 to
77e1c7d
Compare
3bc5c35 to
4986d43
Compare
4986d43 to
8930660
Compare
c8778fa to
f5cdb1d
Compare
f5cdb1d to
75ed3c5
Compare
75ed3c5 to
e839e7a
Compare
Additional Artifact Review RequiredChanges to artifact directory files requires at least 2 approvals from core team members. |
e839e7a to
21e1cc6
Compare
21e1cc6 to
38eb6d6
Compare
* Add Semantic entities to columns for new YAML * Change changie issue number

Resolves LINEAR JIRA
Depends on #12386 (Update: MERGED :-) )
Problem
We need to support new yaml specs for metrics in the new V2 semantic layer YAML, although there is a lot of overlap. This PR addresses creating the spec for the YAML itself.
Solution
I broke the unparsed metric class into a base class and two different sub-classes based for v1 and v2. I did the same thing for the tests for unparsed metrics. (Sharing a base class and test is especially reasonable in this case because they share validation logic.)
The design goal here is to DRY as much as possible while also making it reasonable to do maintenance on only one version of YAML at once (including eventually surgically removing the old YAML format one day).
Checklist