Skip to content

Add Parsed class for new-style YAML Metric#12161

Merged
QMalcolm merged 2 commits intomainfrom
patricky/add-new-style-yaml-fully-parsed-metric
Jan 29, 2026
Merged

Add Parsed class for new-style YAML Metric#12161
QMalcolm merged 2 commits intomainfrom
patricky/add-new-style-yaml-fully-parsed-metric

Conversation

@theyostalservice
Copy link
Contributor

@theyostalservice theyostalservice commented Nov 11, 2025

Resolves LINEAR JIRA

Depends on #12157and #12395

Problem

We need to actually parse and process the new YAML for metrics (introduced in #12157 ). You can see this file for the schema agreed on for V2 Semantic YAML here and already implemented in fusion.

This PR will deal with ONLY parsing metrics that are found outside of semantic models. Parsing those actually on semantic models will require slightly more work on top of this.

Solution

Similar to several other recent PRs, I break the the Metric parsing up wherever I can easily do so. Unlike earlier PRs, I don't break apart the processing code for dependencies because it's a little complex and stuck inside manifest.py, and I'd rather do any breaking up of that file in its own separate PR if we decide its necessary.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Nov 11, 2025
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link
Contributor Author

theyostalservice commented Nov 11, 2025

@theyostalservice theyostalservice changed the title Add new-syle YAML (Parsed) Metric Add Parsed class for new-style YAML Metric Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 76.10619% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.29%. Comparing base (db5a9e0) to head (65e0bfc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12161      +/-   ##
==========================================
- Coverage   91.41%   91.29%   -0.13%     
==========================================
  Files         203      203              
  Lines       25207    25282      +75     
==========================================
+ Hits        23044    23081      +37     
- Misses       2163     2201      +38     
Flag Coverage Δ
integration 88.12% <75.22%> (-0.20%) ⬇️
unit 65.20% <26.54%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 65.20% <26.54%> (-0.14%) ⬇️
Integration Tests 88.12% <75.22%> (-0.20%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@theyostalservice theyostalservice changed the base branch from patricky/add-new-metric-yaml to graphite-base/12161 November 11, 2025 18:36
@theyostalservice theyostalservice force-pushed the patricky/add-new-style-yaml-fully-parsed-metric branch from 2c6ae4d to 1d31380 Compare November 12, 2025 21:00
@github-actions
Copy link
Contributor

Additional Artifact Review Required

Changes to artifact directory files requires at least 2 approvals from core team members.

@theyostalservice theyostalservice changed the base branch from graphite-base/12161 to patricky/add-new-metric-yaml November 12, 2025 21:00
@theyostalservice theyostalservice force-pushed the patricky/add-new-style-yaml-fully-parsed-metric branch 6 times, most recently from 717094e to 677d0b7 Compare November 13, 2025 21:07
@theyostalservice theyostalservice force-pushed the patricky/add-new-style-yaml-fully-parsed-metric branch from 677d0b7 to 69c2f50 Compare January 25, 2026 20:48
@theyostalservice theyostalservice force-pushed the patricky/add-new-metric-yaml branch from f5cdb1d to 75ed3c5 Compare January 25, 2026 20:48
@theyostalservice theyostalservice force-pushed the patricky/add-new-style-yaml-fully-parsed-metric branch from 69c2f50 to 7af3b00 Compare January 26, 2026 18:27
@theyostalservice theyostalservice force-pushed the patricky/add-new-metric-yaml branch from 75ed3c5 to e839e7a Compare January 26, 2026 18:27
@theyostalservice theyostalservice changed the base branch from patricky/add-new-metric-yaml to graphite-base/12161 January 27, 2026 02:09
@theyostalservice theyostalservice force-pushed the patricky/add-new-style-yaml-fully-parsed-metric branch from 7af3b00 to 4a42b9b Compare January 27, 2026 02:13
@theyostalservice theyostalservice changed the base branch from graphite-base/12161 to patricky/add-column-entities January 27, 2026 02:13
@theyostalservice theyostalservice force-pushed the patricky/add-new-style-yaml-fully-parsed-metric branch 2 times, most recently from 59f1971 to 78b7514 Compare January 27, 2026 04:36
@theyostalservice theyostalservice force-pushed the patricky/add-column-entities branch from 4acb1df to 9898c22 Compare January 27, 2026 05:04
@theyostalservice theyostalservice force-pushed the patricky/add-new-style-yaml-fully-parsed-metric branch 5 times, most recently from 4b7e9fd to 84e4212 Compare January 27, 2026 19:42
@theyostalservice theyostalservice added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label Jan 27, 2026 — with Graphite App
@theyostalservice theyostalservice marked this pull request as ready for review January 27, 2026 19:46
@theyostalservice theyostalservice requested a review from a team as a code owner January 27, 2026 19:46
@github-actions github-actions bot added the community This PR is from a community member label Jan 27, 2026
@theyostalservice theyostalservice mentioned this pull request Jan 28, 2026
5 tasks
WilliamDee
WilliamDee previously approved these changes Jan 28, 2026
@theyostalservice theyostalservice changed the base branch from patricky/add-column-entities to graphite-base/12161 January 28, 2026 21:09
@theyostalservice theyostalservice force-pushed the patricky/add-new-style-yaml-fully-parsed-metric branch from 84e4212 to 9aa1596 Compare January 28, 2026 21:11
@theyostalservice theyostalservice changed the base branch from graphite-base/12161 to patricky/add-column-entities January 28, 2026 21:11
Base automatically changed from patricky/add-column-entities to patricky/add-new-metric-yaml January 28, 2026 21:37
Base automatically changed from patricky/add-new-metric-yaml to main January 28, 2026 23:34
@QMalcolm QMalcolm dismissed WilliamDee’s stale review January 28, 2026 23:34

The base branch was changed.

@QMalcolm QMalcolm force-pushed the patricky/add-new-style-yaml-fully-parsed-metric branch from 9aa1596 to 65e0bfc Compare January 29, 2026 00:02
@QMalcolm
Copy link
Contributor

Bypassing because the checks all passed, and we just dropped duplicate commits 🙈

@QMalcolm QMalcolm merged commit abb58d7 into main Jan 29, 2026
51 checks passed
@QMalcolm QMalcolm deleted the patricky/add-new-style-yaml-fully-parsed-metric branch January 29, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes community This PR is from a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants