Add Parsed class for new-style YAML Metric#12161
Merged
Conversation
Contributor
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Contributor
Author
This was referenced Nov 11, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12161 +/- ##
==========================================
- Coverage 91.41% 91.29% -0.13%
==========================================
Files 203 203
Lines 25207 25282 +75
==========================================
+ Hits 23044 23081 +37
- Misses 2163 2201 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
8930660 to
f5cdb1d
Compare
2c6ae4d to
1d31380
Compare
Contributor
Additional Artifact Review RequiredChanges to artifact directory files requires at least 2 approvals from core team members. |
717094e to
677d0b7
Compare
677d0b7 to
69c2f50
Compare
f5cdb1d to
75ed3c5
Compare
5 tasks
69c2f50 to
7af3b00
Compare
75ed3c5 to
e839e7a
Compare
5 tasks
7af3b00 to
4a42b9b
Compare
e839e7a to
4acb1df
Compare
59f1971 to
78b7514
Compare
4acb1df to
9898c22
Compare
4b7e9fd to
84e4212
Compare
5 tasks
WilliamDee
previously approved these changes
Jan 28, 2026
5 tasks
84e4212 to
9aa1596
Compare
9898c22 to
634b0ba
Compare
Base automatically changed from
patricky/add-column-entities
to
patricky/add-new-metric-yaml
January 28, 2026 21:37
9aa1596 to
65e0bfc
Compare
Contributor
|
Bypassing because the checks all passed, and we just dropped duplicate commits 🙈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves LINEAR JIRA
Depends on #12157and #12395
Problem
We need to actually parse and process the new YAML for metrics (introduced in #12157 ). You can see this file for the schema agreed on for V2 Semantic YAML here and already implemented in fusion.
This PR will deal with ONLY parsing metrics that are found outside of semantic models. Parsing those actually on semantic models will require slightly more work on top of this.
Solution
Similar to several other recent PRs, I break the the Metric parsing up wherever I can easily do so. Unlike earlier PRs, I don't break apart the processing code for dependencies because it's a little complex and stuck inside manifest.py, and I'd rather do any breaking up of that file in its own separate PR if we decide its necessary.
Checklist