debezium/dbz#1097 Add support for connection validator for Milvus#310
Open
kartikangiras wants to merge 5 commits intodebezium:mainfrom
Open
debezium/dbz#1097 Add support for connection validator for Milvus#310kartikangiras wants to merge 5 commits intodebezium:mainfrom
kartikangiras wants to merge 5 commits intodebezium:mainfrom
Conversation
Author
mfvitale
reviewed
Mar 23, 2026
Member
|
Hi @kartikangiras Overall it LGMT. I just left a minor comment and started the CI |
jpechane
reviewed
Mar 23, 2026
...r/src/test/java/io/debezium/platform/environment/connection/MilvusConnectionValidatorIT.java
Show resolved
Hide resolved
...r/src/test/java/io/debezium/platform/environment/connection/MilvusConnectionValidatorIT.java
Show resolved
Hide resolved
jpechane
approved these changes
Mar 26, 2026
Member
|
@kartikangiras failure seems related. Could you please take a look? |
Signed-off-by: Kartik Angiras <angiraskartik@gmail.com>
…validation tests Signed-off-by: Kartik Angiras <angiraskartik@gmail.com>
…s test common Signed-off-by: Kartik Angiras <angiraskartik@gmail.com>
Author
|
@mfvitale I have added certain test dependencies due to which CI check was failing. |
mfvitale
reviewed
Mar 26, 2026
...conductor/src/test/java/io/debezium/platform/environment/database/db/MilvusTestResource.java
Show resolved
Hide resolved
mfvitale
requested changes
Mar 26, 2026
Author
|
@mfvitale I have placed the MilvusTestResource under the test directory now. |
Signed-off-by: Kartik Angiras <angiraskartik@gmail.com>
kmos
reviewed
Mar 26, 2026
.../java/io/debezium/platform/environment/connection/destination/MilvusConnectionValidator.java
Outdated
Show resolved
Hide resolved
.../java/io/debezium/platform/environment/connection/destination/MilvusConnectionValidator.java
Outdated
Show resolved
Hide resolved
Naros
reviewed
Mar 27, 2026
Comment on lines
+174
to
+175
| if (errorMessage.contains("timeout") || errorMessage.contains("TimeoutException") || | ||
| errorMessage.contains("deadline")) { |
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
I think, in general, that we should improve sink error management. So this could be something we could approach during DS rewrite?
Member
|
@kartikangiras Could you take a look to test failures? |
Author
Yeah sure, I'm on it. |
Signed-off-by: Kartik Angiras <angiraskartik@gmail.com>
Author
|
@mfvitale I have resolved all the comments and made relevant changes Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
fixes debezium/dbz#1097
DBZ-9440