fix: file-type dep mismatch version on node_modules override#1870
Merged
fix: file-type dep mismatch version on node_modules override#1870
Conversation
c9b1ac9 to
5d688ac
Compare
5d688ac to
63521b4
Compare
LautaroPetaccio
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
GET /content/contents/:idendpoint was failing on most requests with:Root cause:
The Dockerfile merges dependencies by copying
content/node_modules/ into the root node_modules/. This overlay replacesfile-type@15(a root workspace dependency) withfile-type@21(content's dependency), but leaves behind the stale nestednode_modules/file-type/node_modules/token-types@2.1.1from the old version. At runtime,file-type@21resolves token-types to this stalev2.1.1 (CJS, uses Buffer.readInt32BE)instead of the correctv6.1.1 (ESM, uses DataView with Uint8Array), causing the crash.Fix:
Remove
file-type@15from rootnode_modules/before overlaying content's dependencies, ensuringfile-type@21is installed cleanly without stale nested dependencies