Skip to content

fix: throttle tree generation when the player teleports#7210

Open
lorux0 wants to merge 2 commits intodevfrom
fix/thread-lock
Open

fix: throttle tree generation when the player teleports#7210
lorux0 wants to merge 2 commits intodevfrom
fix/thread-lock

Conversation

@lorux0
Copy link
Collaborator

@lorux0 lorux0 commented Feb 23, 2026

What does this PR change?

Fixes #7150

A fix has been introduced here: #6643 to regenerate the terrain props whenever the user moves between realms. That is OK, however the process is very expensive due more than 100k iterations (depending on how many trees and props).

Screenshot 2026-02-24 at 10 47 37

The changes introduces a throttling over frames to re-generate the trees (1000 trees every frame).

Test Instructions

Follow steps from this issue: #5873

  1. Go to any empty parcel
  2. Go to a world
  3. Go back to any empty parcel
  4. Go to any scene
  5. Check that you dont see trees overlapping the scenes nor worlds
  6. The load times will be higher, check that takes a reasonable duration

Quality Checklist

  • Changes have been tested locally
  • Documentation has been updated (if required)
  • Performance impact has been considered
  • For SDK features: Test scene is included

Code Review Reference

Please review our Code Review Standards before submitting.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026

badge

Build failed! Check the logs to see what went wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System.TimeoutException: MultiThreadSync timeout, cannot acquire for: EngineAPIImplementation, current owner: "ECSLoopSystem" takes too long: 10.0286898

2 participants