Open
Conversation
mcandeia
requested changes
May 23, 2025
| metadataString, | ||
| metadataUint8Array, | ||
| }); | ||
| return { metadata: "", binaryData }; |
Contributor
There was a problem hiding this comment.
I'd say metadata can't be a string but rather an object, however there's no way to parse data without metadata information, so my preference is to rethrow the error instead of creating inconsistent behaviours returning empty strings and arbitrary data.
Contributor
There was a problem hiding this comment.
Suggested change
| return { metadata: "", binaryData }; | |
| throw error; |
Contributor
|
Also, if there are any unhandled exceptions you can set a global unhandled rejection handler preventing the application to panic when such case happened. here: https://github.com/deco-sites/simpletunnel/blob/main/main.ts globalThis.onunhandledrejection = function() {
console.error("Unhandled rejection");
};rectifying that this should be placed on simpletunnel rather than here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.