Skip to content

[Fix] - add logs #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabrielMatosBoubee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Fix] - add logs #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions serializers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,23 @@ function parseMessage(
// Read the metadata
const metadataUint8Array = new Uint8Array(buffer, 4, metadataLength);
const metadataString = new TextDecoder().decode(metadataUint8Array);
const metadata = JSON.parse(metadataString);

// Read the binary data
const binaryData = new Uint8Array(buffer, 4 + metadataLength);
try {
const metadata = JSON.parse(metadataString);

return { metadata, binaryData };
return { metadata, binaryData };
} catch (error) {
console.log({
error,
buffer,
binaryData,
metadataString,
metadataUint8Array,
});
return { metadata: "", binaryData };
Copy link
Contributor

@mcandeia mcandeia May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say metadata can't be a string but rather an object, however there's no way to parse data without metadata information, so my preference is to rethrow the error instead of creating inconsistent behaviours returning empty strings and arbitrary data.

Copy link
Contributor

@mcandeia mcandeia May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return { metadata: "", binaryData };
throw error;

}
}

export const arrayBufferSerializer = (): MessageSerializer<
Expand Down