Skip to content

Conversation

@jnumainville
Copy link
Collaborator

Adds docs for basic info on titles and legends

@jnumainville jnumainville requested a review from dsmmcken May 2, 2025 16:59
@github-actions github-actions bot requested a review from margaretkennedy May 2, 2025 16:59
Copy link
Contributor

@dsmmcken dsmmcken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be added to sidebar as well.

Can you also include examples for how to hide the legend and how to position the legend on the top/bottom/left/right, which seem to be common AI questions? (Likely update_figure?)

@jnumainville
Copy link
Collaborator Author

I do have one example in the unsafe_update_figure doc for location. Would that example be better housed here or should I link to that document and add the remaining examples there? I'd lean to linking to that doc for the moment as I know we would like to add legend options directly eventually.

@dsmmcken
Copy link
Contributor

I feel like as a user I would have looked in this doc for anything related to legends based on the title being "titles and legends". I get the argument for putting it in unsafe update though.

I would be tempted to put all legends stuff in here, and then link to unsafe_update in any explanatory text.

@github-actions
Copy link

plotly-express docs preview (Available for 14 days)

@jnumainville jnumainville requested a review from dsmmcken May 13, 2025 17:24
Copy link
Contributor

@dsmmcken dsmmcken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, minor typo.

@jnumainville jnumainville enabled auto-merge (squash) May 15, 2025 14:50
@github-actions
Copy link

plotly-express docs preview (Available for 14 days)

1 similar comment
@github-actions
Copy link

plotly-express docs preview (Available for 14 days)

@jnumainville jnumainville merged commit 9df65df into deephaven:main May 20, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants