fix: Fixes for nested dashboards/deephaven.ui#2648
Open
mofojed wants to merge 2 commits intodeephaven:mainfrom
Open
fix: Fixes for nested dashboards/deephaven.ui#2648mofojed wants to merge 2 commits intodeephaven:mainfrom
mofojed wants to merge 2 commits intodeephaven:mainfrom
Conversation
- Add a class name for widgets loaded from the widget-loader so we know what kind of panel it is - Allows specific styling to be applied for panels loaded with widget-loader - Add metadata to widget component props type - It's already gets passed through, just adding it to the type
mofojed
added a commit
to mofojed/deephaven-plugins
that referenced
this pull request
Mar 30, 2026
- Needs deephaven/web-client-ui#2648 - WidgetPlugin just registers directly - Allows for nested ui.resolve deephaven.ui components - Still maintain DashboardPlugin to handle legacy behaviour - Works with the ui_home_screen, nested dashboards, etc - Styling a little bit different (ui.panel is automatically wrapped in a nested dashboard rather than opening up panels in the existing dashboard like before) - Dashboard now has a `show_headers` option that can be set to False to not show headers on a dashboard. Useful if you're doing a homescreen type dashboard
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2648 +/- ##
=======================================
Coverage 49.81% 49.81%
=======================================
Files 774 774
Lines 43868 43869 +1
Branches 11107 11107
=======================================
+ Hits 21851 21852 +1
Misses 21999 21999
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vbabich
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.