[0.34.0-dlc] Fix typo in _extract_lora_adapter function#2928
Merged
xyang16 merged 1 commit intodeepjavalibrary:0.34.0-dlcfrom Oct 29, 2025
Merged
[0.34.0-dlc] Fix typo in _extract_lora_adapter function#2928xyang16 merged 1 commit intodeepjavalibrary:0.34.0-dlcfrom
xyang16 merged 1 commit intodeepjavalibrary:0.34.0-dlcfrom
Conversation
ethnzhng
approved these changes
Oct 29, 2025
Member
|
Are we making a patch release of v16 ? Without this fix, Lora CX is essentially broken I believe ? |
Lokiiiiii
reviewed
Oct 29, 2025
| adapter_name = raw_request.get_property( | ||
| SAGEMAKER_ADAPTER_IDENTIFIER_HEADER) | ||
| logging.debug(f"Found adapter in headers: {adapter_name}") | ||
| elif "adapter" in decoded_payload: |
Member
There was a problem hiding this comment.
Can we accept both "adapter" or "adapters" with a defined preference and warning ?
I worry this will break CX for customers who have already started using "adapter"
Contributor
Author
There was a problem hiding this comment.
For sagemaker users, they always use SAGEMAKER_ADAPTER_IDENTIFIER_HEADER, adapters in the payload is a legacy behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about
Type of change
Please delete options that are not relevant.
Checklist:
pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B