Skip to content

[0.34.0-dlc] Fix typo in _extract_lora_adapter function#2928

Merged
xyang16 merged 1 commit intodeepjavalibrary:0.34.0-dlcfrom
xyang16:0.34.0-dlc
Oct 29, 2025
Merged

[0.34.0-dlc] Fix typo in _extract_lora_adapter function#2928
xyang16 merged 1 commit intodeepjavalibrary:0.34.0-dlcfrom
xyang16:0.34.0-dlc

Conversation

@xyang16
Copy link
Copy Markdown
Contributor

@xyang16 xyang16 commented Oct 29, 2025

Description

Brief description of what this PR is about

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Please add the link of Integration Tests Executor run with related tests.
  • Have you manually built the docker image and verify the change?
  • Have you run related tests? Check how to set up the test environment here; One example would be pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

@xyang16 xyang16 requested review from a team and zachgk as code owners October 29, 2025 18:41
@xyang16 xyang16 merged commit c3b8633 into deepjavalibrary:0.34.0-dlc Oct 29, 2025
5 of 6 checks passed
@Lokiiiiii
Copy link
Copy Markdown
Member

Are we making a patch release of v16 ? Without this fix, Lora CX is essentially broken I believe ?

adapter_name = raw_request.get_property(
SAGEMAKER_ADAPTER_IDENTIFIER_HEADER)
logging.debug(f"Found adapter in headers: {adapter_name}")
elif "adapter" in decoded_payload:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we accept both "adapter" or "adapters" with a defined preference and warning ?

I worry this will break CX for customers who have already started using "adapter"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sagemaker users, they always use SAGEMAKER_ADAPTER_IDENTIFIER_HEADER, adapters in the payload is a legacy behavior.

@xyang16 xyang16 deleted the 0.34.0-dlc branch October 30, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants