Skip to content

[0.34.0-dlc] Fix typo in _extract_lora_adapter function #2928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xyang16 merged 1 commit into from
Oct 29, 2025
Merged

[0.34.0-dlc] Fix typo in _extract_lora_adapter function #2928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions engines/python/setup/djl_python/async_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@ def _extract_lora_adapter(raw_request, decoded_payload):
adapter_name = raw_request.get_property(
SAGEMAKER_ADAPTER_IDENTIFIER_HEADER)
logging.debug(f"Found adapter in headers: {adapter_name}")
elif "adapter" in decoded_payload:
Copy link
Copy Markdown
Member

@Lokiiiiii Lokiiiiii Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we accept both "adapter" or "adapters" with a defined preference and warning ?

I worry this will break CX for customers who have already started using "adapter"

Copy link
Copy Markdown
Contributor Author

@xyang16 xyang16 Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sagemaker users, they always use SAGEMAKER_ADAPTER_IDENTIFIER_HEADER, adapters in the payload is a legacy behavior.

adapter_name = decoded_payload.pop("adapter")
elif "adapters" in decoded_payload:
adapter_name = decoded_payload.pop("adapters")
logging.debug(f"Found adapter in payload: {adapter_name}")

return adapter_name
Expand Down
Loading