Skip to content

Changed to use custom s5cmd build w go 1.24.2 to address CVEs#2934

Closed
smouaa wants to merge 1 commit intomasterfrom
s5cmd-fix-clean
Closed

Changed to use custom s5cmd build w go 1.24.2 to address CVEs#2934
smouaa wants to merge 1 commit intomasterfrom
s5cmd-fix-clean

Conversation

@smouaa
Copy link
Contributor

@smouaa smouaa commented Oct 31, 2025

Also added new integration tests for DJL CPU container to workflow

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

@smouaa smouaa requested review from a team and zachgk as code owners October 31, 2025 21:30
- test: TestStatefulModel
instance: g6
failure-prefix: lmi
- test: TestSagemakerCompatibility
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I also add TestXgbSkl and TestCustomFormatters to tests.py? I was told to separate them into different files because it made tests.py very long

Copy link
Contributor

@xyang16 xyang16 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, it doesn't work if it's not in tests.py though. But please double check.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing you can do is to import TestSagemakerCompatibility, TestXgbSkl and TestCustomFormatters in tests.py if you want to keep them separate.

@xyang16 xyang16 self-requested a review October 31, 2025 21:37
Copy link
Contributor

@xyang16 xyang16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please run the nightly before merge?

@xyang16 xyang16 self-requested a review October 31, 2025 21:39
@smouaa smouaa closed this Nov 1, 2025
@smouaa smouaa deleted the s5cmd-fix-clean branch November 13, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants