Changed to use custom s5cmd build w go 1.24.2 to address CVEs#2934
Changed to use custom s5cmd build w go 1.24.2 to address CVEs#2934
Conversation
.github/workflows/integration.yml
Outdated
| - test: TestStatefulModel | ||
| instance: g6 | ||
| failure-prefix: lmi | ||
| - test: TestSagemakerCompatibility |
There was a problem hiding this comment.
You need to add TestSagemakerCompatibility to https://github.com/deepjavalibrary/djl-serving/blob/master/tests/integration/tests.py
There was a problem hiding this comment.
Should I also add TestXgbSkl and TestCustomFormatters to tests.py? I was told to separate them into different files because it made tests.py very long
There was a problem hiding this comment.
I see, it doesn't work if it's not in tests.py though. But please double check.
There was a problem hiding this comment.
One thing you can do is to import TestSagemakerCompatibility, TestXgbSkl and TestCustomFormatters in tests.py if you want to keep them separate.
xyang16
left a comment
There was a problem hiding this comment.
Could you please run the nightly before merge?
c7715cf to
918bcec
Compare
…o added new integration tests to workflow
918bcec to
6e1d79c
Compare
Also added new integration tests for DJL CPU container to workflow
Description
Brief description of what this PR is about
Type of change
Please delete options that are not relevant.
Checklist:
pytest tests.py -k "TestVllm1" -m "vllm"Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B