Skip to content

Conversation

@Critsium-xy
Copy link
Collaborator

There is no MPI_Finalize function in the WARNING_QUIT tool. So it may cause mpi warning or segfault at the time that the software quits when running on multiple CPU cores. This PR fixed this.

Fix #5486

@Critsium-xy Critsium-xy marked this pull request as ready for review April 22, 2025 07:10
@Critsium-xy Critsium-xy force-pushed the ADVANCED_WARNING_QUIT branch from 650910e to 5f59f2c Compare April 22, 2025 09:54
@mohanchen mohanchen added the Refactor Refactor ABACUS codes label Apr 22, 2025
@Critsium-xy Critsium-xy force-pushed the ADVANCED_WARNING_QUIT branch from 8ed3e73 to 82c8211 Compare April 23, 2025 14:24
@mohanchen mohanchen merged commit 8fc7c42 into deepmodeling:develop Apr 24, 2025
14 checks passed
@Critsium-xy Critsium-xy deleted the ADVANCED_WARNING_QUIT branch June 26, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Refactor ABACUS codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: function WARNING_QUIT does not finalize the MPI processes correctly

2 participants