Skip to content

Fix: add MPI_Finalize in QUIT function #6160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 24, 2025
Merged

Fix: add MPI_Finalize in QUIT function #6160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0fe4035
Add Finalize function in WARNING QUIT
Critsium-xy Apr 22, 2025
4a80c35
Fix compilation error
Critsium-xy Apr 22, 2025
08903bb
Nooo I haven't been writing codes for a long timeeeeee
Critsium-xy Apr 22, 2025
5f59f2c
Remove dependency test
Critsium-xy Apr 22, 2025
d901a1d
Confirm removal
Critsium-xy Apr 22, 2025
82c8211
Remove useless Dependency
Critsium-xy Apr 23, 2025
72e0135
Merge branch 'develop' into ADVANCED_WARNING_QUIT
Critsium-xy Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions source/module_base/tool_quit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,20 @@ void QUIT(int ret)
void WARNING_QUIT(const std::string &file,const std::string &description)
{
WARNING_QUIT(file, description, 1);

#ifdef __MPI /* if it is MPI run, finalize first, then exit */
std::cout << "Detecting if MPI has been initialized..." << std::endl;
int is_initialized;
MPI_Initialized(&is_initialized);
if (is_initialized) {
std::cout << "Terminating ABACUS with multiprocessing environment." << std::endl;
MPI_Finalize();
}
else{
std::cout << "MPI has not been initialized. Quit normally." << std::endl;
}
/* but seems this is the only correct way to terminate the MPI */
#endif
}

void WARNING_QUIT(const std::string &file,const std::string &description,int ret)
Expand Down
1 change: 0 additions & 1 deletion source/module_basis/module_pw/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ AddTest(
SOURCES ../../../module_base/matrix.cpp ../../../module_base/complexmatrix.cpp ../../../module_base/matrix3.cpp ../../../module_base/tool_quit.cpp
../../../module_base/mymath.cpp ../../../module_base/timer.cpp ../../../module_base/memory.cpp ../../../module_base/blas_connector.cpp
../../../module_base/libm/branred.cpp ../../../module_base/libm/sincos.cpp
# ../../../module_psi/kernels/psi_memory_op.cpp
../../../module_base/module_device/memory_op.cpp
depend_mock.cpp pw_test.cpp test1-1-1.cpp test1-1-2.cpp test1-2.cpp test1-3.cpp test1-4.cpp test1-5.cpp
test2-1-1.cpp test2-1-2.cpp test2-2.cpp test2-3.cpp
Expand Down
Loading