fix: TCP connection leak and metric overflow (#365, #366) #372
+111
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add context manager support and atexit handlers to iovec/ioring classes to address symlink leakage issues reported in deepseek-ai#334. Changes: - Add global symlink registry with thread-safe lock for tracking - Add atexit handler _cleanup_symlinks() for cleanup on normal exit - Add context manager protocol (__enter__/__exit__) to iovec class - Add context manager protocol to ioring class - Add explicit close() methods with idempotent behavior - Replace simple __del__ with close() call for safe cleanup This ensures symlinks in /3fs-virt/iovs/ are cleaned up even when: - Exceptions occur during I/O operations - The process exits normally without explicit cleanup - Users forget to manually unlink symlinks 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
…ek-ai#366) 1. Fix TCP connection leak (deepseek-ai#365): - Add TCP connection cleanup in checkConnectionsRegularly() - Previously only RDMA connections were checked for expiration 2. Fix metric overflow (deepseek-ai#366): - Increment connectedCount when creating new outgoing connections - This matches the decrement in remove() for symmetry 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
kaede11
reviewed
Dec 30, 2025
| XLOGF(DBG9, "server@{} check connections", fmt::ptr(this)); | ||
| // Check both RDMA and TCP connections for expiration | ||
| ioWorker().checkConnections(Address{0, 0, Address::RDMA}, config_.connection_expiration_time()); | ||
| ioWorker().checkConnections(Address{0, 0, Address::TCP}, config_.connection_expiration_time()); |
There was a problem hiding this comment.
当集群规模较大，或者连接数较大时，这两个checkConnections是会block 协程调度的，感觉可以定期yield一下，让出cpu。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
checkConnectionsRegularly()connectedCountwhen creating new outgoing connectionsChanges
checkConnectionsRegularly()connectedCountwhen creating new connections to match decrement inremove()Test plan
max_connectionscommon.net.connected_countmetric doesn't overflow🤖 Generated with Claude Code