Skip to content

fix: TCP connection leak and metric overflow (#365, #366) #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yurekami wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: TCP connection leak and metric overflow (#365, #366) #372

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b250b38
fix(io): Add robust symlink cleanup to prevent resource leakage
yurekami Dec 25, 2025
7bbb48e
fix: TCP connection leak and metric overflow (#365, #366)
yurekami Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/common/net/ServiceGroup.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ void ServiceGroup::stopAndJoin() {
CoTask<void> ServiceGroup::checkConnectionsRegularly() {
while (true) {
XLOGF(DBG9, "server@{} check connections", fmt::ptr(this));
// Check both RDMA and TCP connections for expiration
ioWorker().checkConnections(Address{0, 0, Address::RDMA}, config_.connection_expiration_time());
ioWorker().checkConnections(Address{0, 0, Address::TCP}, config_.connection_expiration_time());
Copy link

@kaede11 kaede11 Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当集群规模较大，或者连接数较大时，这两个checkConnections是会block 协程调度的，感觉可以定期yield一下，让出cpu。

co_await folly::coro::sleep(config_.check_connections_interval().asMs());
}
}
Expand Down
4 changes: 3 additions & 1 deletion src/common/net/TransportPool.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,9 @@ std::pair<TransportPtr, bool> TransportPool::get(Address addr, IOWorker &io_work
// 3. create a new transport. still protected by mutex.
transport = Transport::create(addr, io_worker);
set.add(transport, idx);
acceptedCountRecorder.set(++acceptedCount);
// Increment connectedCount for outgoing connections (addr.ip != 0)
// to match the decrement in remove() for symmetry
connectedCountRecorder.set(++connectedCount);
cached = transport;
return std::make_pair(std::move(transport), true);
},
Expand Down