feat: NvidiaChatGenerator add integration tests for mixing Tool/Toolset
#2422
+190
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:nvidia
type:documentation
Amnah199
reviewed
Oct 21, 2025
Comment on lines
427
to
429
| # Pass echo_tool as a list at runtime - runtime tools should take precedence | ||
| messages = [ChatMessage.from_user("Echo this: Hello World")] | ||
| results = component.run(messages, tools=[echo_tool]) |
There was a problem hiding this comment.
Same comment about mixing tools and toolsets at runtime.
There was a problem hiding this comment.
but this one is different: there is no mention of tools and we need to wrap single tool into a list
Amnah199
reviewed
Oct 21, 2025
Comment on lines
337
to
338
| def test_integration_mixing_init_and_runtime_tools(self): | ||
| """Test mixing tools from init and runtime by passing tools to both __init__ and run().""" |
There was a problem hiding this comment.
I am not sure if this test was intended. We can rather have a test for ser/deser of mixed tool lists like in GoogleGenAiChatGenerator.
There was a problem hiding this comment.
@vblagoje lets remove this test. I still dont see the need of keeping it. The rest looks good.
Amnah199
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Add integration tests for
ToolsTypeHaystack 2.19 updatespart of:
What:
How did you test it: