perf(path): only clone string for the path #3841
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Slight change in the find_files by only cloning the string for the path (from this PR)
Benchmark
Before optimization:
Time: 668.73 µs
Clones all fields: path, partition_values HashMap, stats strings, etc.
After optimization:
Time: 366.62 µs
Only clones the path String once
Moves the Add struct instead of deep cloning