Skip to content

Conversation

@fvaleye
Copy link
Collaborator

@fvaleye fvaleye commented Oct 12, 2025

Description

Slight change in the find_files by only cloning the string for the path (from this PR)

Benchmark

  • Before optimization:
    Time: 668.73 µs
    Clones all fields: path, partition_values HashMap, stats strings, etc.

  • After optimization:
    Time: 366.62 µs
    Only clones the path String once
    Moves the Add struct instead of deep cloning

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Oct 12, 2025
@codecov
Copy link

codecov bot commented Oct 12, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.30%. Comparing base (4cf1bea) to head (f07602c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/delta_datafusion/find_files.rs 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3841      +/-   ##
==========================================
- Coverage   74.32%   74.30%   -0.02%     
==========================================
  Files         147      147              
  Lines       39717    39700      -17     
  Branches    39717    39700      -17     
==========================================
- Hits        29518    29500      -18     
- Misses       8808     8810       +2     
+ Partials     1391     1390       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Nice improvement at very low cost!

Eventually, I hope we can eliminate operations using add actions directly and do this all on the (filtered to what's needed) arrow data directly. But that certainly is a larger effort for another day 😄.

@ion-elgreco ion-elgreco merged commit acd75d6 into delta-io:main Oct 12, 2025
26 checks passed
roeap added a commit that referenced this pull request Oct 18, 2025
# Description

In one of @fvaleye's latest PRs (#3841), we got rid of the last call
sites of `file_actions` on `DeltaTableState`. Since we generally
discourage materialising `Add` actions and rather do processing/planning
on the view into the underlying arrow data, it's high time we deprecate
these methods and remove the last invocations within our tests.

This PR does just that.

Signed-off-by: Robert Pack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/rust Issues for the Rust crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants