Conversation
- new language: slovenian - removed empty language files (except hebrew) - adapted script to remove empty files automatically
|
|
||
| electron-to-chromium@1.5.267: {} | ||
|
|
||
| electron-winstaller@5.4.0: |
There was a problem hiding this comment.
So are we fine with doing this upgrade after all? We talked about this in #6105.
There was a problem hiding this comment.
I thought the issue with #6105 was if we want to upgrade electron-builder from 26.7 to 26.8. It's a bit weird that electron-builder-squirrel-windows was still on 24.x while electron-builder was on 26.x.
I didn't look deeper into that but just tested if it works (when I updated electron-builder 26.x). So you expect that this change affects the build process even if electron-builder stays on 26.7 ?
I will have a look on the build machine. And if it causes trouble I still can downgrade again, so let's not block the core upgrade
There was a problem hiding this comment.
So you expect that this change affects the build process even if electron-builder stays on 26.7 ?
yes. See the MR that I mentioned:
Note that this adds the
electron-winstallerdependency, which has a build script which we did not add toonlyBuiltDependencies.
- remove empty he.xml file - remove he as language since there are no translations
nicodh
force-pushed
the
update-core-2.45.0
branch
from
6d2a926 to
dcb2b01
Compare
|
Maybe it's worth doing another |
2 participants
Since we have new stock strings I also updated the translations
To avoid having to delete empty files manually I added a task to our find-complete-translations script to remove these files. It turned out, that hebrew is listed as language although it has no translations which doesn't make sense so we removed it for now as long as there are no translations available.