Skip to content

refactor: rewrite node_compat tests with file_test_runner #31792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsherret merged 5 commits into from
Jan 9, 2026
Merged

refactor: rewrite node_compat tests with file_test_runner #31792

dsherret merged 5 commits into from
Jan 9, 2026

Conversation

@dsherret
Copy link
Member

@dsherret dsherret commented Jan 8, 2026 •
edited
Loading

Reasons:

  1. Uses the same test infrastructure as the rest of the integration tests.
    • Runs flaky test in isolation on the CI.
    • Gets rid of duplicate logic we already have.
  2. We get reporting on failed tests.

@dsherret dsherret force-pushed the feat_node_compat_tests_ci_report branch from ef9279e to 3abaedb Compare January 8, 2026 02:24
dsherret
dsherret commented Jan 8, 2026
View reviewed changes
tests/util/server/src/test_runner.rs
Copy link
Member Author

@dsherret dsherret Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug fix for on failure it wouldn't clear properly sometimes.

dsherret
dsherret commented Jan 8, 2026
View reviewed changes
tests/node_compat/config.json
Copy link
Member Author

@dsherret dsherret Jan 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to json so we don't have to add a toml parser dependency

Copy link
Member

@bartlomieju bartlomieju Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

bartlomieju
bartlomieju reviewed Jan 8, 2026
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix tools/node_compat_tests.js?

@dsherret
Copy link
Member Author

dsherret commented Jan 8, 2026

Can you please fix tools/node_compat_tests.js?

Good catch. I removed this file because we don't need it anymore.

@dsherret dsherret requested a review from bartlomieju January 8, 2026 21:15
@dsherret dsherret merged commit 30d1a95 into denoland:main Jan 9, 2026
31 of 36 checks passed
@dsherret dsherret deleted the feat_node_compat_tests_ci_report branch January 9, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dsherret @bartlomieju