Skip to content

refactor: rewrite node_compat tests with file_test_runner #31792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsherret merged 5 commits into from
Jan 9, 2026
Merged

refactor: rewrite node_compat tests with file_test_runner #31792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3abaedb
refactor: rewrite node_compat tests with file_test_runner
dsherret Jan 8, 2026
8a5f03e
Fix.
dsherret Jan 8, 2026
0b0a3a3
Merge branch 'main' into feat_node_compat_tests_ci_report
dsherret Jan 8, 2026
6b26676
Update
dsherret Jan 8, 2026
58d9773
remove tools/node_compat_tests.js
dsherret Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,9 @@ path = "unit_node/mod.rs"
harness = false

[[test]]
name = "node_compat_tests"
path = "node_compat/test_runner.rs"
name = "node_compat"
path = "node_compat/mod.rs"
harness = false

[dev-dependencies]
anyhow.workspace = true
Expand Down
2 changes: 1 addition & 1 deletion tests/node_compat/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Deno.
If you run single node.js test case, use the command:

```
./tools/node_compat_tests.js --filter <name of test file>
cargo test <name of test file>
```

## Configuration file
Expand Down
46 changes: 0 additions & 46 deletions tests/node_compat/common.ts
View file
Open in desktop

This file was deleted.

1,528 changes: 1,528 additions & 0 deletions tests/node_compat/config.json
View file
Open in desktop
Copy link
Member Author

@dsherret dsherret Jan 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to json so we don't have to add a toml parser dependency

Copy link
Member

@bartlomieju bartlomieju Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

Large diffs are not rendered by default.

1,482 changes: 0 additions & 1,482 deletions tests/node_compat/config.toml
View file
Open in desktop

This file was deleted.

Loading
Loading