Skip to content

add option to lint diff buffers#3185

Merged
w0rp merged 4 commits intodense-analysis:masterfrom
blobmasterbrian:add-diff-lint-option
Feb 6, 2026
Merged

add option to lint diff buffers#3185
w0rp merged 4 commits intodense-analysis:masterfrom
blobmasterbrian:add-diff-lint-option

Conversation

@blobmasterbrian
Copy link
Copy Markdown
Contributor

Adds an option to lint diff buffers as suggested below:
#2583

Tests added, documentation updated.

@Hnasar
Copy link
Copy Markdown

Hnasar commented Jun 10, 2020

Looks good! Thanks for the patch. We'll need a maintainer to review though.

@stale
Copy link
Copy Markdown

stale bot commented Aug 13, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs/Issues no longer valid label Aug 13, 2020
@stale stale bot closed this Aug 15, 2020
@blobmasterbrian
Copy link
Copy Markdown
Contributor Author

@w0rp tests have been written and documentation added. Can we reopen this and get it merged?

@blobmasterbrian
Copy link
Copy Markdown
Contributor Author

@Hnasar @w0rp can we add this functionality?

@blobmasterbrian
Copy link
Copy Markdown
Contributor Author

@w0rp @Hnasar after using vim-lsp as a standalone for a few years, I'm coming back to using ALE precisely because the error messaging in vim-lsp in diff buffers caused odd jumping around the file. I hadn't realized this was never merged because I had it locally, but if I'm coming back because vim-lsp is insufficient for diff buffers then it doesn't really make sense if it's not supported. Can we reopen and merge this?

@hsanson hsanson reopened this Nov 22, 2025
@stale stale bot removed the stale PRs/Issues no longer valid label Nov 22, 2025
@blobmasterbrian
Copy link
Copy Markdown
Contributor Author

Am I missing something here? I don't want to obnoxiously bump, but I also don't want it to get stale.

@blobmasterbrian
Copy link
Copy Markdown
Contributor Author

Another gentle bump

@w0rp w0rp merged commit e762262 into dense-analysis:master Feb 6, 2026
14 checks passed
@w0rp
Copy link
Copy Markdown
Member

w0rp commented Feb 6, 2026

Cheers! 🍻

Nothing but a simple 5 year turnaround on merging a PR. Sorry about that. 😆

hsanson added a commit to hsanson/ale that referenced this pull request Mar 28, 2026
* upstream/master:
  Added support for harper in markdown files (dense-analysis#5104)
  fix(phpcs): run from project root instead of file directory (dense-analysis#5105)
  support running solargraph via bundle (dense-analysis#5097)
  Fix dense-analysis#5062 - Keep ALE LSP compatible with Neovim 0.10 and 0.11+
  Tell OpenCode how to write ALE code
  feat(rstcheck): Add automatic --config support with version check (dense-analysis#5095)
  Truncate astro test files to quiet dependabot
  Skip ALE docker download attempts
  doc goimport (dense-analysis#5093)
  refactor: use ale#Pad for option padding across the codebase (dense-analysis#5091)
  add option to lint diff buffers (dense-analysis#3185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants