Fix command options mode (InputOption::VALUE_REQUIRED) #4091
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonmedv
reviewed
Jul 1, 2025
| ->setName('init') | ||
| ->setDescription('Initialize deployer in your project') | ||
| ->addOption('path', 'p', InputOption::VALUE_OPTIONAL, 'Recipe path'); | ||
| ->addOption('path', 'p', InputOption::VALUE_REQUIRED, 'Recipe path'); |
Contributor
Author
There was a problem hiding this comment.
Options are always optional. But when using this option, a value is required.
Valid is init or init --path=/foo/bar.
But init --path without the value is invalid. So the value is not optional for this option.
Contributor
Author
There was a problem hiding this comment.
It is a common mistake. Even in symfony itself I found some wrong usages of VALUE_OPTIONAL: symfony/symfony#60914
antonmedv
requested changes
Jul 1, 2025
| { | ||
| parent::configure(); | ||
| $this->addOption('format', null, InputOption::VALUE_OPTIONAL, 'The output format (json, yaml)', 'yaml'); | ||
| $this->addOption('format', null, InputOption::VALUE_REQUIRED, 'The output format (json, yaml)', 'yaml'); |
Member
There was a problem hiding this comment.
It is optional and yaml by default.
antonmedv
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using these options, a value is required.