Skip to content

Fix command options mode (InputOption::VALUE_REQUIRED) #4091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonmedv merged 1 commit into from
Jul 1, 2025
+2 −2
Merged

Fix command options mode (InputOption::VALUE_REQUIRED) #4091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Command/ConfigCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public function __construct(Deployer $deployer)
protected function configure()
{
parent::configure();
$this->addOption('format', null, InputOption::VALUE_OPTIONAL, 'The output format (json, yaml)', 'yaml');
$this->addOption('format', null, InputOption::VALUE_REQUIRED, 'The output format (json, yaml)', 'yaml');
Copy link
Member

@antonmedv antonmedv Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is optional and yaml by default.

$this->getDefinition()->getArgument('selector')->setDefault(['all']);
}

Expand Down
2 changes: 1 addition & 1 deletion src/Command/InitCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ protected function configure()
$this
->setName('init')
->setDescription('Initialize deployer in your project')
->addOption('path', 'p', InputOption::VALUE_OPTIONAL, 'Recipe path');
->addOption('path', 'p', InputOption::VALUE_REQUIRED, 'Recipe path');
Copy link
Member

@antonmedv antonmedv Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is optional!

Copy link
Contributor Author

@gharlan gharlan Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Options are always optional. But when using this option, a value is required.
Valid is init or init --path=/foo/bar.
But init --path without the value is invalid. So the value is not optional for this option.

Copy link
Contributor Author

@gharlan gharlan Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a common mistake. Even in symfony itself I found some wrong usages of VALUE_OPTIONAL: symfony/symfony#60914

}

protected function execute(InputInterface $input, OutputInterface $output): int
Expand Down
Loading