fix(pubsub): add explicit dependency for dead letter topic IAM permission#11
Merged
nathanknowles merged 1 commit intomainfrom Jan 26, 2026
Merged
fix(pubsub): add explicit dependency for dead letter topic IAM permission#11nathanknowles merged 1 commit intomainfrom
nathanknowles merged 1 commit intomainfrom
Conversation
…sion The Pub/Sub subscription with a dead letter policy could be created before the Pub/Sub service account was granted publish permission on the dead letter topic. Terraform was creating the subscription and IAM binding in parallel, which caused a race condition. Add an explicit depends_on from the subscription to the google_pubsub_topic_iam_member resource to ensure the publisher permission is granted before the subscription is created. This prevents failed messages from being dropped due to missing permissions on the dead letter topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pub/Sub subscription with a dead letter policy could be created before
the Pub/Sub service account was granted publish permission on the dead letter
topic. Terraform was creating the subscription and IAM binding in parallel,
which caused a race condition.
Add an explicit depends_on from the subscription to the
google_pubsub_topic_iam_member resource to ensure the publisher permission
is granted before the subscription is created.
This prevents failed messages from being dropped due to missing permissions
on the dead letter topic.