Skip to content

[universal] - Fixing multiple image vulnerability issues#1745

Merged
abdurriq merged 6 commits intodevcontainers:mainfrom
Kaniska244:universal-vulnerability-issues
Jan 22, 2026
Merged

[universal] - Fixing multiple image vulnerability issues#1745
abdurriq merged 6 commits intodevcontainers:mainfrom
Kaniska244:universal-vulnerability-issues

Conversation

@Kaniska244
Copy link
Contributor

@Kaniska244 Kaniska244 commented Jan 21, 2026

Ref# Issue details

Dev container name:

  • universal

Description:

This PR patches the following vulnerabilities:

Changelog:

  • Updated patch-conda/install.sh

    • Upgraded version for patched python package
      • cryptography - minimum package version has been set to 44.0.1
      • brotli - minimum package version has been set to 1.2.0
      • urllib3 - minimum package version has been set to 2.6.3
  • Updated patch-python/install.sh

    • Upgraded version for patched python package
      • pip - upgraded to latest versionn
      • setuptools - minimum package version has been set to 78.1.1
  • Added local-feature patch-python back in the image build.

  • Small update in test script to test updated versions.

  • Version bump.

Checklist:

  • Checked that applied changes work as expected

@Kaniska244 Kaniska244 marked this pull request as ready for review January 21, 2026 16:50
@Kaniska244 Kaniska244 requested a review from a team as a code owner January 21, 2026 16:50
Copilot AI review requested due to automatic review settings January 21, 2026 16:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies security patches to address multiple vulnerabilities in Python packages within the universal dev container image. The changes update package versions for cryptography, pip, setuptools, urllib3, and brotli to remediate reported CVEs and GitHub Security Advisories.

Changes:

  • Added patch-python local feature to upgrade pip and setuptools in the Python 3.11 installation
  • Updated patch-conda to upgrade cryptography, urllib3, and add brotli package updates
  • Bumped manifest version from 5.1.1 to 5.1.2 (patch version) and synchronized README

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/universal/manifest.json Version bump from 5.1.1 to 5.1.2
src/universal/README.md Updated example version tag to 5.1.2-noble
src/universal/.devcontainer/devcontainer.json Added patch-python feature to features list and install order
src/universal/.devcontainer/local-features/patch-python/install.sh Added pip upgrade and setuptools 78.1.1 minimum version enforcement
src/universal/.devcontainer/local-features/patch-conda/install.sh Updated cryptography to 44.0.1, urllib3 to 2.6.3, and added brotli 1.2.0
src/universal/test-project/test.sh Added/updated version checks for patched packages
src/universal/.devcontainer/devcontainer-lock.json Auto-updated feature dependency versions (docker-in-docker, dotnet)
Comments suppressed due to low confidence (2)

src/universal/.devcontainer/local-features/patch-python/install.sh:45

  • The glob pattern /usr/local/python/3.11.*/bin/python may not expand correctly when passed to the update_package function because the sudo_if function wraps the command in quotes. This prevents shell glob expansion. Consider using the symlink path /usr/local/python/current/bin/python instead, which is the standard approach used elsewhere in the codebase (see machine-learning-packages/install.sh).
update_package /usr/local/python/3.11.*/bin/python setuptools "78.1.1"

src/universal/.devcontainer/devcontainer.json:91

  • This line uses tab characters for indentation while the rest of the file uses spaces. This creates inconsistent indentation. Please change the indentation to use spaces (8 spaces) to match the surrounding code.
		"./local-features/patch-python",

abdurriq
abdurriq previously approved these changes Jan 21, 2026
@Kaniska244 Kaniska244 requested a review from abdurriq January 22, 2026 10:59
@abdurriq abdurriq merged commit 1bca3d1 into devcontainers:main Jan 22, 2026
2 checks passed
This was referenced Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants