[universal] - Fixing multiple image vulnerability issues#1745
Merged
abdurriq merged 6 commits intodevcontainers:mainfrom Jan 22, 2026
Merged
[universal] - Fixing multiple image vulnerability issues#1745abdurriq merged 6 commits intodevcontainers:mainfrom
abdurriq merged 6 commits intodevcontainers:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies security patches to address multiple vulnerabilities in Python packages within the universal dev container image. The changes update package versions for cryptography, pip, setuptools, urllib3, and brotli to remediate reported CVEs and GitHub Security Advisories.
Changes:
- Added patch-python local feature to upgrade pip and setuptools in the Python 3.11 installation
- Updated patch-conda to upgrade cryptography, urllib3, and add brotli package updates
- Bumped manifest version from 5.1.1 to 5.1.2 (patch version) and synchronized README
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/universal/manifest.json | Version bump from 5.1.1 to 5.1.2 |
| src/universal/README.md | Updated example version tag to 5.1.2-noble |
| src/universal/.devcontainer/devcontainer.json | Added patch-python feature to features list and install order |
| src/universal/.devcontainer/local-features/patch-python/install.sh | Added pip upgrade and setuptools 78.1.1 minimum version enforcement |
| src/universal/.devcontainer/local-features/patch-conda/install.sh | Updated cryptography to 44.0.1, urllib3 to 2.6.3, and added brotli 1.2.0 |
| src/universal/test-project/test.sh | Added/updated version checks for patched packages |
| src/universal/.devcontainer/devcontainer-lock.json | Auto-updated feature dependency versions (docker-in-docker, dotnet) |
Comments suppressed due to low confidence (2)
src/universal/.devcontainer/local-features/patch-python/install.sh:45
- The glob pattern
/usr/local/python/3.11.*/bin/pythonmay not expand correctly when passed to theupdate_packagefunction because thesudo_iffunction wraps the command in quotes. This prevents shell glob expansion. Consider using the symlink path/usr/local/python/current/bin/pythoninstead, which is the standard approach used elsewhere in the codebase (see machine-learning-packages/install.sh).
update_package /usr/local/python/3.11.*/bin/python setuptools "78.1.1"
src/universal/.devcontainer/devcontainer.json:91
- This line uses tab characters for indentation while the rest of the file uses spaces. This creates inconsistent indentation. Please change the indentation to use spaces (8 spaces) to match the surrounding code.
"./local-features/patch-python",
abdurriq
reviewed
Jan 21, 2026
src/universal/.devcontainer/local-features/patch-conda/install.sh
Outdated
Show resolved
Hide resolved
abdurriq
previously approved these changes
Jan 21, 2026
abdurriq
approved these changes
Jan 22, 2026
This was referenced Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref# Issue details
Dev container name:
Description:
This PR patches the following vulnerabilities:
cryptographypackage.pip.setuptoolspackage.urllib3package.brotlipackage.Changelog:
Updated patch-conda/install.sh
cryptography- minimum package version has been set to44.0.1brotli- minimum package version has been set to1.2.0urllib3- minimum package version has been set to2.6.3Updated patch-python/install.sh
pip- upgraded to latest versionnsetuptools- minimum package version has been set to78.1.1Added local-feature
patch-pythonback in the image build.Small update in test script to test updated versions.
Version bump.
Checklist: