Conversation
|
📚 Documentation preview will be available at: https://developmentseed.github.io/titiler-cmr/pr-previews/pr-73/ Status: ✅ Preview is ready! |
vincentsarago
approved these changes
Sep 10, 2025
hrodmn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a step on the road to observability in titiler-cmr! The OpenTelemetry dependencies bring us dangerously close to the Lambda code size limit, but we are still under. After we merge this change we can consider our options for collecting the OpenTelemetry traces somewhere (either via Lambda or some other service).
I hit a snag when removing boto3 and botocore from our asset package (which was necessary to conserve space) - the Python 3.12 runtime image has version 1.34.145 of boto3 and botocore installed, but when you actually execute the function it turns out that we have version 1.40.4! I have the aiobotocore/boto3/botocore versions pinned loosely to versions that are at least compatible enough for s3fs and fsspec.
All of this has me thinking that #64 is the next step because that should bring our package size down a bit and get us out of the brittle boto3/botocore/aiobotocore situation.