Skip to content

Conversation

@Jdubrick
Copy link
Contributor

Description of Changes

Summarize the changes you made as part of this pull request.

This PR updates the Lifecycle doc to reflect the handling of Stack Providers that are external to Red Hat.

Related Issue(s)

Link the GitHub/GitLab/JIRA issues that are related to this PR.

fixes devfile/api#1650

Acceptance Criteria

  • Contributing guide

Have you read the devfile registry contributing guide and followed its instructions?

  • Test automation

Does this repository's tests pass with your changes?

  • Documentation

Does any documentation need to be updated with your changes?

  • Check Tools Provider

Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

N/A

How To Test

Instructions for the reviewer on how to test your changes.

N/A

Notes To Reviewer

Any notes you would like to include for the reviewer.

N/A

@Jdubrick Jdubrick requested a review from a team as a code owner November 22, 2024 15:47
@openshift-ci openshift-ci bot requested a review from johnmcollier November 22, 2024 15:47
Signed-off-by: Jordan Dubrick <[email protected]>
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Nov 22, 2024
@openshift-ci
Copy link

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick Jdubrick merged commit 2e83f42 into devfile:main Nov 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Looks good to me

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Registry Lifecycle

2 participants