#1058: fixed missing JAVA_HOME env var

[jan-vcapgemini]

Fixes: #1058

Implements:

• fixed mvn encrypt password
• replaced new ProcessContext with runTool
• added check for mvn settings security file
• added new getSingleOutput method to ProcessResult
• added new retrievePassword method to Mvn

[coveralls]

Pull Request Test Coverage Report for Build 14975449259

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 55 unchanged lines in 4 files lost coverage.
• Overall coverage increased (+0.03%) to 67.679%

---

Files with Coverage Reduction	New Missed Lines	%
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java	1	77.59%
com/devonfw/tools/ide/process/ProcessContext.java	5	30.0%
com/devonfw/tools/ide/process/ProcessResultImpl.java	23	51.35%
com/devonfw/tools/ide/tool/mvn/Mvn.java	26	65.5%

Totals
Change from base Build 14972411443:	0.03%
Covered Lines:	7974
Relevant Lines:	11374

---

💛 - Coveralls

[hohwille]

@jan-vcapgemini thanks for your PR. You implemented everything exactly as I expected.

However, I tested this and found a new bug:

[ERROR] Error executing Maven.
[ERROR] The specified user settings file does not exist: D:\projects\test\conf\mvn\settings.xml

So in that case already the creation of the master password is failing.
Should we add a check for the existence before adding the -s option?

IDEasy/cli/src/main/java/com/devonfw/tools/ide/tool/mvn/Mvn.java

Lines 250 to 262 in 9f839b2

	public String getMavenArgs() {
	Path mavenConfFolder = getMavenConfFolder(false);
	Path mvnSettingsFile = mavenConfFolder.resolve(Mvn.SETTINGS_FILE);
	if (!Files.exists(mvnSettingsFile)) {
	return null;
	}
	String settingsPath = mvnSettingsFile.toString();
	return "-s " + settingsPath + " " + getSettingsSecurityProperty();
	}
	private String getSettingsSecurityProperty() {
	return "-Dsettings.security=" + this.context.getMavenConfigurationFolder().resolve(SETTINGS_SECURITY_FILE).toString().replace("\\", "\\\\");
	}

IMHO that would make sense.

[jan-vcapgemini]

@jan-vcapgemini thanks for your PR. You implemented everything exactly as I expected.

However, I tested this and found a new bug:

[ERROR] Error executing Maven.
[ERROR] The specified user settings file does not exist: D:\projects\test\conf\mvn\settings.xml

So in that case already the creation of the master password is failing. Should we add a check for the existence before adding the -s option?

IDEasy/cli/src/main/java/com/devonfw/tools/ide/tool/mvn/Mvn.java

Lines 250 to 262 in 9f839b2

	public String getMavenArgs() {
	Path mavenConfFolder = getMavenConfFolder(false);
	Path mvnSettingsFile = mavenConfFolder.resolve(Mvn.SETTINGS_FILE);
	if (!Files.exists(mvnSettingsFile)) {
	return null;
	}
	String settingsPath = mvnSettingsFile.toString();
	return "-s " + settingsPath + " " + getSettingsSecurityProperty();
	}
	private String getSettingsSecurityProperty() {
	return "-Dsettings.security=" + this.context.getMavenConfigurationFolder().resolve(SETTINGS_SECURITY_FILE).toString().replace("\\", "\\\\");
	}

IMHO that would make sense.

I can't reproduce this bug. Could you please add the preparations/steps to reproduce it?

[jan-vcapgemini]

I've added a check for the existence of the mvn settings security file now.

[hohwille]

@jan-vcapgemini thanks for your rework and improvements. 👍
I still have some CRs to be addressed before merge.

[hohwille]

build failed with:

[ERROR] com.devonfw.tools.ide.tool.mvn.MvnTest.testMvnInstall -- Time elapsed: 0.050 s <<< FAILURE!
java.lang.AssertionError: 

Expecting path:
  /home/runner/work/IDEasy/IDEasy/cli/target/test-projects/mvn/project/conf/mvn/settings.xml
to exist (symbolic links were followed).
	at com.devonfw.tools.ide.tool.mvn.MvnTest.checkInstallation(MvnTest.java:76)
	at com.devonfw.tools.ide.tool.mvn.MvnTest.testMvnInstall(MvnTest.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

I did not yet see which change prevents that this file gets created.

[hohwille]

11:26:54.715 [main] - INFO - c.d.tools.ide.log.IdeSubLoggerSlf4j - STEP:Start: Create mvn settings file at /home/runner/work/IDEasy/IDEasy/cli/target/test-projects/mvn/project/conf/.m2/settings.xml
11:26:54.715 [main] - INFO - c.d.tools.ide.log.IdeSubLoggerSlf4j - Please enter secret value for variable login:
11:26:54.715 [main] - DEBUG - c.d.tools.ide.log.IdeSubLoggerSlf4j - Running command '/home/runner/work/IDEasy/IDEasy/cli/target/test-projects/mvn/_ide/software/default/mvn/mvn/3.9.7/bin/mvn' using bash with arguments '--encrypt-password' 'testLogin' '-Dsettings.security=/home/runner/work/IDEasy/IDEasy/cli/target/test-projects/mvn/project/conf/.m2/settings-security.xml' ...
11:26:54.718 [main] - INFO - c.d.tools.ide.log.IdeSubLoggerSlf4j - Encrypted as testLogin
11:26:54.718 [main] - INFO - c.d.tools.ide.log.IdeSubLoggerSlf4j - Please enter secret value for variable password:
11:26:54.718 [main] - DEBUG - c.d.tools.ide.log.IdeSubLoggerSlf4j - Running command '/home/runner/work/IDEasy/IDEasy/cli/target/test-projects/mvn/_ide/software/default/mvn/mvn/3.9.7/bin/mvn' using bash with arguments '--encrypt-password' 'testPassword' '-Dsettings.security=/home/runner/work/IDEasy/IDEasy/cli/target/test-projects/mvn/project/conf/.m2/settings-security.xml' ...
11:26:54.721 [main] - INFO - c.d.tools.ide.log.IdeSubLoggerSlf4j - Encrypted as testPassword
11:26:54.722 [main] - INFO - c.d.tools.ide.log.IdeSubLoggerSlf4j - SUCCESS:Successfully ended step 'Create mvn settings file at /home/runner/work/IDEasy/IDEasy/cli/target/test-projects/mvn/project/conf/.m2/settings.xml'.
11:26:54.722 [main] - DEBUG - c.d.tools.ide.log.IdeSubLoggerSlf4j - Step 'Create mvn settings file at /home/runner/work/IDEasy/IDEasy/cli/target/test-projects/mvn/project/conf/.m2/settings.xml' ended successfully.

[hohwille]

Is this maybe part of the problem:

  private void createSettingsFile(Path settingsFile, Path settingsSecurityFile, Path settingsTemplateFile) {
    if (Files.exists(settingsFile) || !Files.exists(settingsSecurityFile)) {
      return;
    }

Also why do we have the second if condition? Maybe the settings.xml file contains no variable, then it should also be created without a settings-security.xml file.