add hidden prop to connector config #3818
Conversation
Signed-off-by: Giovanni Vella <giovanni.vella98@gmail.com>
cardoe
left a comment
cardoe
left a comment
There was a problem hiding this comment.
This would be a great addition.
|
@nabokihms and @sagikazarmark what do you think of this? |
|
To further this along, I've pulled this PR into build that I made at https://github.com/cardoe/dex/releases/tag/v2.44.90 You can grab the container to test with at ghcr.io/cardoe/dex:v2.44.90 and report back on this PR. |
|
Hi @cardoe, I've tested ghcr.io/cardoe/dex:v2.44.90 with the connector property "hidden: true" and it works as expected! |
| // or making Dex reading both tags and act accordingly. | ||
| Config []byte `json:"email"` | ||
| // It specifies if the connector should be hidden in the login web page. | ||
| Hidden bool `json:"hidden"` |
There was a problem hiding this comment.
Unfortunately, this isn't enough for the storage layer.
Try adding it to this test: https://github.com/dexidp/dex/blob/master/storage/conformance/conformance.go#L616
Conformance tests will fail and you will see that you need to change.
Generally, any schema based storage will have to be updated as well.
There was a problem hiding this comment.
Hi @sagikazarmark, I updated the db schema but the tests still fail due to this issue #4461
Signed-off-by: Giovanni Vella <giovanni.vella98@gmail.com>
3 participants
Overview
Added config property to hide a connector in the login web page, for example if it should be used only for m2m.
What this PR does / why we need it
As requested in #3145 and #4231
Adds connector's config property "hidden" (default false).
Related
Discussion: Can I hide a connector? #3145