add hidden prop to connector config

cmd/dex/config.go

@@ -365,9 +365,10 @@ func (s *Storage) UnmarshalJSON(b []byte) error {
 // Connector is a magical type that can unmarshal YAML dynamically. The
 // Type field determines the connector type, which is then customized for Config.
 type Connector struct {
-	Type string `json:"type"`
-	Name string `json:"name"`
-	ID   string `json:"id"`
+	Type   string `json:"type"`
+	Name   string `json:"name"`
+	ID     string `json:"id"`
+	Hidden bool   `json:"hidden"`
 
 	Config server.ConnectorConfig `json:"config"`
 }
@@ -376,9 +377,10 @@ type Connector struct {
 // dynamically determine the type of the connector config.
 func (c *Connector) UnmarshalJSON(b []byte) error {
 	var conn struct {
-		Type string `json:"type"`
-		Name string `json:"name"`
-		ID   string `json:"id"`
+		Type   string `json:"type"`
+		Name   string `json:"name"`
+		ID     string `json:"id"`
+		Hidden bool   `json:"hidden"`
 
 		Config json.RawMessage `json:"config"`
 	}
@@ -422,6 +424,7 @@ func (c *Connector) UnmarshalJSON(b []byte) error {
 		Name:   conn.Name,
 		ID:     conn.ID,
 		Config: connConfig,
+		Hidden: conn.Hidden,
 	}
 	return nil
 }
@@ -438,6 +441,7 @@ func ToStorageConnector(c Connector) (storage.Connector, error) {
 		Type:   c.Type,
 		Name:   c.Name,
 		Config: data,
+		Hidden: c.Hidden,
 	}, nil
 }
 

server/handlers.go

@@ -183,10 +183,11 @@ func (s *Server) handleAuthorization(w http.ResponseWriter, r *http.Request) {
 	for index, conn := range connectors {
 		connURL.Path = s.absPath("/auth", url.PathEscape(conn.ID))
 		connectorInfos[index] = connectorInfo{
-			ID:   conn.ID,
-			Name: conn.Name,
-			Type: conn.Type,
-			URL:  template.URL(connURL.String()),
+			ID:     conn.ID,
+			Name:   conn.Name,
+			Type:   conn.Type,
+			URL:    template.URL(connURL.String()),
+			Hidden: conn.Hidden,
 		}
 	}
 

server/templates.go

@@ -249,10 +249,11 @@ var scopeDescriptions = map[string]string{
 }
 
 type connectorInfo struct {
-	ID   string
-	Name string
-	URL  template.URL
-	Type string
+	ID     string
+	Name   string
+	URL    template.URL
+	Type   string
+	Hidden bool
 }
 
 type byName []connectorInfo
@@ -283,11 +284,17 @@ func (t *templates) deviceSuccess(r *http.Request, w http.ResponseWriter, client
 }
 
 func (t *templates) login(r *http.Request, w http.ResponseWriter, connectors []connectorInfo) error {
-	sort.Sort(byName(connectors))
+	var visibleConnectors []connectorInfo
+	for _, connector := range connectors {
+		if !connector.Hidden {
+			visibleConnectors = append(visibleConnectors, connector)
+		}
+	}
+	sort.Sort(byName(visibleConnectors))
 	data := struct {
 		Connectors []connectorInfo
 		ReqPath    string
-	}{connectors, r.URL.Path}
+	}{visibleConnectors, r.URL.Path}
 	return renderTemplate(w, t.loginTmpl, data)
 }
 

storage/conformance/conformance.go

@@ -622,6 +622,7 @@ func testConnectorCRUD(t *testing.T, s storage.Storage) {
 		Type:   "Default",
 		Name:   "Default",
 		Config: config1,
+		Hidden: false,
 	}
 
 	if err := s.CreateConnector(ctx, c1); err != nil {
@@ -639,6 +640,7 @@ func testConnectorCRUD(t *testing.T, s storage.Storage) {
 		Type:   "Mock",
 		Name:   "Mock",
 		Config: config2,
+		Hidden: false,
 	}
 
 	if err := s.CreateConnector(ctx, c2); err != nil {

storage/ent/client/connector.go

@@ -14,6 +14,7 @@ func (d *Database) CreateConnector(ctx context.Context, connector storage.Connec
 		SetType(connector.Type).
 		SetResourceVersion(connector.ResourceVersion).
 		SetConfig(connector.Config).
+		SetHidden(connector.Hidden).
 		Save(ctx)
 	if err != nil {
 		return convertDBError("create connector: %w", err)