Merged
Conversation
yhabib
approved these changes
Feb 28, 2025
Contributor
yhabib
left a comment
yhabib
left a comment
There was a problem hiding this comment.
LGTM left a few minor comments.
I hope we aren't planning to use it with so many items 😅. If we expect to have more than 6 or 7, we should consider using a dropdown instead 🙈.
added 2 commits
February 28, 2025 17:46
Contributor
Author
This is for demo purposes only; currently, a maximum of four elements is planned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
For the new table sorting UI in the NNS Dapp, we need a ChipGroup component.
Changes
Screenshots
Many CI screenshots have been updated due to the new component in the side menu. Additionally, one mobile screenshot was updated due to the absence of the top header, which was introduced some time ago, though I’m not sure why it happened now.
Light theme
Dark theme
