feat: use resuming downloads for file downloader#4415
Merged
NikolaMilosa merged 31 commits intomasterfrom Mar 26, 2025
Merged
Conversation
eichhorl
reviewed
Mar 18, 2025
eichhorl
reviewed
Mar 18, 2025
eichhorl
reviewed
Mar 19, 2025
basvandijk
reviewed
Mar 20, 2025
Contributor
kpop-dfinity
left a comment
kpop-dfinity
left a comment
There was a problem hiding this comment.
left some comments, mostly nits/style
Contributor
|
About the PR title: I don't think |
NikolaMilosa
dismissed
github-actions[bot]’s stale review
Shouldn't be here. Mistake in merging
DFINITYManu
reviewed
Mar 26, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
This chore builds on top of #4415. Previously we had two ways of downloading ic os images. This PR enforces the use of `FileDownloader` utility that has support for resuming downloads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To tackle problems with low bandwidth networks and connectivity issues we can try using resuming downloads.