fix: replay attacks after canister migration #7787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraszyk
commented
Nov 26, 2025
mraszyk
force-pushed
the
mraszyk/canister-migration-replay-call
branch
from
80da55f to
610848d
Compare
randombit
approved these changes
Dec 1, 2025
Contributor
randombit
left a comment
randombit
left a comment
There was a problem hiding this comment.
Fine re comment in validator source, did not review migration_canister changes
This was referenced Dec 2, 2025
eichhorl
pushed a commit
that referenced
this pull request
Dec 2, 2025
This PR makes the `migration_status` endpoint of the migration canister return only a single or no migration status for a given pair of canister IDs. This PR also fixes the duration of waiting for a completed migration in the canister migration system test to 7 minutes (since the migration canister now waits for at least 6 minutes before completing canister migration to prevent replay attacks - see [PR](#7787)). To prevent such regressions in the future, this PR adds the system test to `PULL_REQUEST_BAZEL_TARGETS` and tags the test as `long_test` so that it can run on PRs using `PULL_REQUEST_BAZEL_TARGETS`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents replay attacks after canister migration by waiting at least 6 minutes: 5 minutes and 30 seconds (maximum ingress expiry enforced by ingress validator) and 30 seconds (to account for a clock drift between the two subnets).