-
Notifications
You must be signed in to change notification settings - Fork 372
feat(crypto): CRP-2618 require omitting pre_signature_to_create_in_advance for vetKD #7981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fspreiss
wants to merge
24
commits into
master
Choose a base branch
from
franzstefan/CRP-2618-empty-pre-sig-to-create-in-advance-new
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(crypto): CRP-2618 require omitting pre_signature_to_create_in_advance for vetKD #7981
fspreiss
wants to merge
24
commits into
master
from
franzstefan/CRP-2618-empty-pre-sig-to-create-in-advance-new
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce for vetKD in proposals
mbjorkqvist
approved these changes
Dec 17, 2025
Contributor
mbjorkqvist
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamping DeFi change!
- Done (updated unreleased_changelog.md).
- No breaking changes, given that the
KeyConfig::pre_signatures_to_create_in_advancefield in the registry canister API was alreadyoptional. - No data migration needed.
- No security review needed as not security critical.
eichhorl
reviewed
Dec 17, 2025
michael-weigelt
approved these changes
Dec 17, 2025
eichhorl
approved these changes
Dec 18, 2025
daniel-wong-dfinity-org
approved these changes
Jan 5, 2026
daniel-wong-dfinity-org
approved these changes
Jan 7, 2026
Contributor
daniel-wong-dfinity-org
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts the registry canister and ic-admin so that for {Create|Update|Recover}SubnetPayload the
KeyConfig'spre_signatures_to_create_in_advancefield is no longer needed/allowed for vetKD keys (and generally for keys that don't have pre-signatures). So far, this field was always required, and for vetKD keys this was confusing because vetKD doesn't have the concept of pre-signatures.The protobuf representation in the registry is unchanged, because there the
pre_signatures_to_create_in_advancefield was already optional. For existing registry entries for vetKD keys, the currently set value of 0 remains unchanged, while new entries that are created in the future will not have the field set any more.This change is possible now that the registry canister was recently adapted (see Proposal 139679) to allow omitting
pre_signatures_to_create_in_advancefor keys that don't require it (#7859).An alternative to this approach here would be to turn the
ChainKeyConfig'sKeyConfiginto a protobuf enum. However, this would require an involved multi-step migration of registry data structures.