Skip to content

Conversation

@fspreiss
Copy link
Contributor

@fspreiss fspreiss commented Dec 8, 2025

Adapts the registry canister and ic-admin so that for {Create|Update|Recover}SubnetPayload the KeyConfig's pre_signatures_to_create_in_advance field is no longer needed/allowed for vetKD keys (and generally for keys that don't have pre-signatures). So far, this field was always required, and for vetKD keys this was confusing because vetKD doesn't have the concept of pre-signatures.

The protobuf representation in the registry is unchanged, because there the pre_signatures_to_create_in_advance field was already optional. For existing registry entries for vetKD keys, the currently set value of 0 remains unchanged, while new entries that are created in the future will not have the field set any more.

This change is possible now that the registry canister was recently adapted (see Proposal 139679) to allow omitting pre_signatures_to_create_in_advance for keys that don't require it (#7859).

An alternative to this approach here would be to turn the ChainKeyConfig's KeyConfig into a protobuf enum. However, this would require an involved multi-step migration of registry data structures.

@fspreiss fspreiss changed the title Franzstefan/crp 2618 empty pre sig to create in advance new feat(crypto): CRP-2618 require omitting pre_signature_to_create_in_advance for vetKD Dec 12, 2025
@github-actions github-actions bot added the feat label Dec 12, 2025
@fspreiss fspreiss marked this pull request as ready for review December 17, 2025 08:41
@fspreiss fspreiss requested review from a team as code owners December 17, 2025 08:41
github-actions[bot]

This comment was marked as resolved.

Copy link
Contributor

@mbjorkqvist mbjorkqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamping DeFi change!

@fspreiss fspreiss dismissed github-actions[bot]’s stale review December 17, 2025 08:46
  1. Done (updated unreleased_changelog.md).
  2. No breaking changes, given that the KeyConfig::pre_signatures_to_create_in_advance field in the registry canister API was already optional.
  3. No data migration needed.
  4. No security review needed as not security critical.
Copy link
Contributor

@daniel-wong-dfinity-org daniel-wong-dfinity-org left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants