chore: Fix log filters and refactor code to use log macros#426
Merged
chore: Fix log filters and refactor code to use log macros#426
Conversation
adamspofford-dfinity
force-pushed
the
spofford/log-better
branch
from
ca6fc3a to
955a305
Compare
lwshang
requested changes
Mar 12, 2026
2 tasks
lwshang
approved these changes
Mar 12, 2026
This reverts commit e43af4f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule I have followed is: If, to a person who already knows the tool's behavior, the message would communicate nothing that a status code of 0 would not communicate, it becomes
info!; otherwise, it becomesprintln!.